Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1354813002: Revert of Don't use resolved url for instance identity in ApplicationManager (Closed)

Created:
5 years, 3 months ago by Justin Donnelly
Modified:
5 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't use resolved url for instance identity in ApplicationManager (patchset #4 id:60001 of https://codereview.chromium.org/1346143004/ ) Reason for revert: Need to revert in order to revert https://codereview.chromium.org/1351963002/ which broke https://build.chromium.org/p/chromium.linux/builders/Android%20GN Original issue's description: > Don't use resolved url for instance identity in ApplicationManager > > R=yzshen@chromium.org > http://crbug.com/533085 > > Committed: https://crrev.com/ce9f95edbf5b420aa0f7b0a522112751b547d215 > Cr-Commit-Position: refs/heads/master@{#349541} TBR=yzshen@chromium.org,ben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/27bc389884c6f6214dacb8ce44c7623d863aaf12 Cr-Commit-Position: refs/heads/master@{#349553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -28 lines) Patch
M mojo/package_manager/package_manager_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/package_manager/package_manager_impl.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M mojo/shell/application_manager.h View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/shell/application_manager.cc View 4 chunks +44 lines, -13 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/shell/package_manager.h View 4 chunks +10 lines, -4 lines 0 comments Download
M mojo/shell/test_package_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/test_package_manager.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Donnelly
Created Revert of Don't use resolved url for instance identity in ApplicationManager
5 years, 3 months ago (2015-09-18 00:42:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354813002/1
5 years, 3 months ago (2015-09-18 00:44:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 00:45:56 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 00:46:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27bc389884c6f6214dacb8ce44c7623d863aaf12
Cr-Commit-Position: refs/heads/master@{#349553}

Powered by Google App Engine
This is Rietveld 408576698