Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: content/public/plugin/content_plugin_client.h

Issue 13548005: Add UMA reporting on failure to load ppapi plugins. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: status -> result Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/plugin/DEPS ('K') | « content/ppapi_plugin/ppapi_thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/plugin/content_plugin_client.h
diff --git a/content/public/plugin/content_plugin_client.h b/content/public/plugin/content_plugin_client.h
index b89e46a42826b32b4140559bb64654129df3be12..af6061bc9c60a5c0ac4c8b569311820614437707 100644
--- a/content/public/plugin/content_plugin_client.h
+++ b/content/public/plugin/content_plugin_client.h
@@ -5,6 +5,7 @@
#ifndef CONTENT_PUBLIC_PLUGIN_CONTENT_PLUGIN_CLIENT_H_
#define CONTENT_PUBLIC_PLUGIN_CONTENT_PLUGIN_CLIENT_H_
+#include "base/files/file_path.h"
#include "base/string16.h"
#include "content/public/common/content_client.h"
@@ -13,6 +14,17 @@ namespace content {
// Embedder API for participating in plugin logic.
class CONTENT_EXPORT ContentPluginClient {
public:
+ // Make sure the enum list in tools/histogram/histograms.xml is updated with
+ // any change in this list.
+ enum PluginLoadResult {
+ LOAD_SUCCESS,
+ LOAD_FAILED,
+ ENTRY_POINT_MISSING,
+ INIT_FAILED,
+ // NOTE: Add new values only immediately above this line.
+ LOAD_RESULT_MAX // Boundary value for UMA_HISTOGRAM_ENUMERATION.
+ };
+
virtual ~ContentPluginClient() {}
// Called to perform any per-process initialization necessary before
@@ -21,6 +33,11 @@ class CONTENT_EXPORT ContentPluginClient {
// Notifies that a plugin process has started.
virtual void PluginProcessStarted(const string16& plugin_name) {}
+
+ // Notifies the plugin loading result.
+ virtual void PluginLoaded(const base::FilePath& plugin_path,
+ bool is_broker,
+ PluginLoadResult result) {}
};
} // namespace content
« chrome/plugin/DEPS ('K') | « content/ppapi_plugin/ppapi_thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698