Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: content/public/plugin/content_plugin_client.h

Issue 13548005: Add UMA reporting on failure to load ppapi plugins. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CL refacted. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/plugin/content_plugin_client.h
diff --git a/content/public/plugin/content_plugin_client.h b/content/public/plugin/content_plugin_client.h
index b89e46a42826b32b4140559bb64654129df3be12..12fc8a6d7009bfd3a0b12a158ad183e4d0d7c43a 100644
--- a/content/public/plugin/content_plugin_client.h
+++ b/content/public/plugin/content_plugin_client.h
@@ -5,6 +5,7 @@
#ifndef CONTENT_PUBLIC_PLUGIN_CONTENT_PLUGIN_CLIENT_H_
#define CONTENT_PUBLIC_PLUGIN_CONTENT_PLUGIN_CLIENT_H_
+#include "base/files/file_path.h"
#include "base/string16.h"
#include "content/public/common/content_client.h"
@@ -13,6 +14,15 @@ namespace content {
// Embedder API for participating in plugin logic.
class CONTENT_EXPORT ContentPluginClient {
public:
+ enum PluginLoadStatus {
ddorwin 2013/04/08 18:04:34 Status or Result?
xhwang 2013/04/09 00:34:11 Done.
+ LOAD_SUCCESS,
+ UNKNOWN_ERROR,
piman 2013/04/08 19:38:43 You don't use this. Remove?
xhwang 2013/04/09 00:34:11 Done.
+ LOAD_FAILED,
+ ENTRY_POINT_MISSING,
+ INIT_FAILED,
+ LOAD_STATUS_MAX
piman 2013/04/08 19:38:43 nit: this last value I was very confused about unt
xhwang 2013/04/09 00:34:11 Done.
+ };
+
virtual ~ContentPluginClient() {}
// Called to perform any per-process initialization necessary before
@@ -21,6 +31,10 @@ class CONTENT_EXPORT ContentPluginClient {
// Notifies that a plugin process has started.
virtual void PluginProcessStarted(const string16& plugin_name) {}
+
+ // Notifies that a plugin has been loaded.
ddorwin 2013/04/08 18:04:34 Could also be that a plugin load failed. I'm not s
xhwang 2013/04/09 00:34:11 Done.
+ virtual void PluginLoaded(const base::FilePath& plugin_path,
+ PluginLoadStatus status) {}
};
} // namespace content
« content/ppapi_plugin/ppapi_thread.cc ('K') | « content/ppapi_plugin/ppapi_thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698