Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: content/ppapi_plugin/ppapi_thread.h

Issue 13548005: Add UMA reporting on failure to load ppapi plugins. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Report from PpapiThread. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/ppapi_plugin/ppapi_thread.cc » ('j') | content/ppapi_plugin/ppapi_thread.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/ppapi_plugin/ppapi_thread.h
diff --git a/content/ppapi_plugin/ppapi_thread.h b/content/ppapi_plugin/ppapi_thread.h
index 0e21d5611ea7b5cfd8e17b5ebd9dc7d3bb8a6a5b..5203ce179d7e8a465a0f531db86f8338dedd437f 100644
--- a/content/ppapi_plugin/ppapi_thread.h
+++ b/content/ppapi_plugin/ppapi_thread.h
@@ -49,6 +49,17 @@ class PpapiThread : public ChildThread,
virtual ~PpapiThread();
private:
+ // Make sure the enum list in tools/histogram/histograms.xml is updated with
+ // any change in this list.
+ enum LoadResult {
+ LOAD_SUCCESS,
+ LOAD_FAILED,
+ ENTRY_POINT_MISSING,
+ INIT_FAILED,
+ // NOTE: Add new values only immediately above this line.
+ LOAD_RESULT_MAX // Boundary value for UMA_HISTOGRAM_ENUMERATION.
+ };
+
// This class finds the target PluginDispatcher for each message it receives
// and forwards the message.
class DispatcherMessageListener : public IPC::Listener {
@@ -113,6 +124,8 @@ class PpapiThread : public ChildThread,
// Sets up the name of the plugin for logging using the given path.
void SavePluginName(const base::FilePath& path);
+ void ReportLoadResult(const base::FilePath& path, LoadResult result);
+
// True if running in a broker process rather than a normal plugin process.
bool is_broker_;
« no previous file with comments | « no previous file | content/ppapi_plugin/ppapi_thread.cc » ('j') | content/ppapi_plugin/ppapi_thread.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698