Add UMA reporting on failure to load ppapi plugins.

content/ppapi_plugin/ppapi_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/ppapi_plugin/ppapi_thread.h"
 
 #include <limits>
 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
@@ skipping 241 matching lines @@
 
   // If the plugin isn't internal then load it from |path|.
   base::ScopedNativeLibrary library;
   if (plugin_entry_points_.initialize_module == NULL) {
     // Load the plugin from the specified library.
     std::string error;
     library.Reset(base::LoadNativeLibrary(path, &error));
     if (!library.is_valid()) {
       LOG(ERROR) << "Failed to load Pepper module from "
         << path.value() << " (error: " << error << ")";
+      ReportPluginLoadStatus(path, ContentPluginClient::LOAD_FAILED);
       return;
     }
 
     // Get the GetInterface function (required).

[ddorwin, 2013/04/08 18:04:34]

Unrelated comment: It's strange that we get this for the broker. It appears to
be used in checks that the broker may need to pass, though.

     plugin_entry_points_.get_interface =
         reinterpret_cast<PP_GetInterface_Func>(
             library.GetFunctionPointer("PPP_GetInterface"));
     if (!plugin_entry_points_.get_interface) {
       LOG(WARNING) << "No PPP_GetInterface in plugin library";
+      ReportPluginLoadStatus(path, ContentPluginClient::ENTRY_POINT_MISSING);
       return;
     }
 
     // The ShutdownModule/ShutdownBroker function is optional.
     plugin_entry_points_.shutdown_module =
         is_broker_ ?
         reinterpret_cast<PP_ShutdownModule_Func>(
             library.GetFunctionPointer("PPP_ShutdownBroker")) :
         reinterpret_cast<PP_ShutdownModule_Func>(
             library.GetFunctionPointer("PPP_ShutdownModule"));
 
     if (!is_broker_) {
       // Get the InitializeModule function (required for non-broker code).
       plugin_entry_points_.initialize_module =

[ddorwin, 2013/04/08 18:04:34]

Unrelated comment: It's weird that we save the initialize for the plugin but not
the broker. I guess this is because Remoting Viewer sets this value outside this
function.

           reinterpret_cast<PP_InitializeModule_Func>(
               library.GetFunctionPointer("PPP_InitializeModule"));
       if (!plugin_entry_points_.initialize_module) {
         LOG(WARNING) << "No PPP_InitializeModule in plugin library";
+        ReportPluginLoadStatus(path, ContentPluginClient::ENTRY_POINT_MISSING);
         return;
       }
     }
   }
 
 #if defined(OS_WIN)
   // If code subsequently tries to exit using abort(), force a crash (since
   // otherwise these would be silent terminations and fly under the radar).
   base::win::SetAbortBehaviorForCrashReporting();
   if (permissions.HasPermission(ppapi::PERMISSION_FLASH)) {
@@ skipping 16 matching lines @@
     g_target_services->LowerToken();
   }
 #endif
 
   if (is_broker_) {
     // Get the InitializeBroker function (required).
     InitializeBrokerFunc init_broker =
         reinterpret_cast<InitializeBrokerFunc>(
             library.GetFunctionPointer("PPP_InitializeBroker"));
     if (!init_broker) {
       LOG(WARNING) << "No PPP_InitializeBroker in plugin library";

[ddorwin, 2013/04/08 18:04:34]

This is another ENTRY_POINT_MISSING. Do we want to track broker errors too? Same
with the init errors below. Since we're making the enum, we could add separate
BROKER values.

[xhwang, 2013/04/09 00:34:11]

Added "is_broker" to report UMA for broker separately.

       return;
     }
 
     int32_t init_error = init_broker(&connect_instance_func_);
     if (init_error != PP_OK) {
       LOG(WARNING) << "InitBroker failed with error " << init_error;
       return;
     }
     if (!connect_instance_func_) {
       LOG(WARNING) << "InitBroker did not provide PP_ConnectInstance_Func";
       return;
     }
   } else {
 #if defined(OS_MACOSX)
     // We need to do this after getting |PPP_GetInterface()| (or presumably
     // doing something nontrivial with the library), else the sandbox
     // intercedes.
     CHECK(InitializeSandbox());
 #endif
 
     int32_t init_error = plugin_entry_points_.initialize_module(
         local_pp_module_,
         &ppapi::proxy::PluginDispatcher::GetBrowserInterface);
     if (init_error != PP_OK) {
       LOG(WARNING) << "InitModule failed with error " << init_error;
+      ReportPluginLoadStatus(path, ContentPluginClient::INIT_FAILED);
       return;
     }
   }
 
   // Initialization succeeded, so keep the plugin DLL loaded.
+  ReportPluginLoadStatus(path, ContentPluginClient::LOAD_SUCCESS);
   library_.Reset(library.Release());
 }
 
 void PpapiThread::OnCreateChannel(base::ProcessId renderer_pid,
                                   int renderer_child_id,
                                   bool incognito) {
   IPC::ChannelHandle channel_handle;
 
   if (!plugin_entry_points_.get_interface ||  // Plugin couldn't be loaded.
       !SetupRendererChannel(renderer_pid, renderer_child_id, incognito,
@@ skipping 86 matching lines @@
 
   // From here, the dispatcher will manage its own lifetime according to the
   // lifetime of the attached channel.
   return true;
 }
 
 void PpapiThread::SavePluginName(const base::FilePath& path) {
   ppapi::proxy::PluginGlobals::Get()->set_plugin_name(
       path.BaseName().AsUTF8Unsafe());
 
-  // plugin() is NULL when in-process.  Which is fine, because this is
+  // plugin() is NULL when in-process, which is fine, because this is
   // just a hook for setting the process name.
   if (GetContentClient()->plugin()) {
     GetContentClient()->plugin()->PluginProcessStarted(
         path.BaseName().RemoveExtension().LossyDisplayName());
   }
 }
 
+void PpapiThread::ReportPluginLoadStatus(
+    const base::FilePath& path,
+    ContentPluginClient::PluginLoadStatus status) {
+  // plugin() is NULL when in-process, which is fine, because we only care
+  // about loading status for out-of-process plugins.
+  if (GetContentClient()->plugin())
+    GetContentClient()->plugin()->PluginLoaded(path, status);
+}
+
 }  // namespace content