chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc - Issue 13548003: Prevent leaking geolocation permission from Incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc

Issue 13548003: Prevent leaking geolocation permission from Incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a check to the test Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h ('k') | chrome/browser/geolocation/geolocation_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc

diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc

index 3c61d15ac04628a0f8322fcd9f3a2532442d941e..407a3764d036b85ee0ae7f705d2215d18f94bc98 100644

--- a/chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc

+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc

@@ -82,5 +82,10 @@ void ChromeGeolocationPermissionContextFactory::RegisterUserPrefs(

bool ChromeGeolocationPermissionContextFactory::

ServiceRedirectedInIncognito() const {

+ return false;

+bool ChromeGeolocationPermissionContextFactory::

+ServiceHasOwnInstanceInIncognito() const {

return true;

}