chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h - Issue 13548003: Prevent leaking geolocation permission from Incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h

Issue 13548003: Prevent leaking geolocation permission from Incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc » ('j') | chrome/browser/geolocation/geolocation_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h

diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h b/chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h

index dadd04831acc2d3ff959a94720673f831d5b1663..7f238461680f32eb4279ad382ad02d44fa75dc2e 100644

--- a/chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h

+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h

@@ -33,6 +33,7 @@ class ChromeGeolocationPermissionContextFactory

BuildServiceInstanceFor(Profile* profile) const OVERRIDE;

virtual void RegisterUserPrefs(PrefRegistrySyncable* registry) OVERRIDE;

virtual bool ServiceRedirectedInIncognito() const OVERRIDE;

+ virtual bool ServiceHasOwnInstanceInIncognito() const OVERRIDE;

DISALLOW_COPY_AND_ASSIGN(ChromeGeolocationPermissionContextFactory);

};