chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h - Issue 13548003: Prevent leaking geolocation permission from Incognito

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h

Issue 13548003: Prevent leaking geolocation permission from Incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a check to the test Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_GEOLOCATION_CHROME_GEOLOCATION_PERMISSION_CONTEXT_FACTORY _H_	5 #ifndef CHROME_BROWSER_GEOLOCATION_CHROME_GEOLOCATION_PERMISSION_CONTEXT_FACTORY _H_

6 #define CHROME_BROWSER_GEOLOCATION_CHROME_GEOLOCATION_PERMISSION_CONTEXT_FACTORY _H_	6 #define CHROME_BROWSER_GEOLOCATION_CHROME_GEOLOCATION_PERMISSION_CONTEXT_FACTORY _H_

7	7

8 #include "base/memory/singleton.h"	8 #include "base/memory/singleton.h"

9 #include "base/prefs/pref_service.h"	9 #include "base/prefs/pref_service.h"

10 #include "base/values.h"	10 #include "base/values.h"

(...skipping 15 matching lines...) Expand all Loading...
26 DefaultSingletonTraits<ChromeGeolocationPermissionContextFactory>;	26 DefaultSingletonTraits<ChromeGeolocationPermissionContextFactory>;

27	27

28 ChromeGeolocationPermissionContextFactory();	28 ChromeGeolocationPermissionContextFactory();

29 virtual ~ChromeGeolocationPermissionContextFactory();	29 virtual ~ChromeGeolocationPermissionContextFactory();

30	30

31 // \|ProfileKeyedBaseFactory\| methods:	31 // \|ProfileKeyedBaseFactory\| methods:

32 virtual ProfileKeyedService*	32 virtual ProfileKeyedService*

33 BuildServiceInstanceFor(Profile* profile) const OVERRIDE;	33 BuildServiceInstanceFor(Profile* profile) const OVERRIDE;

34 virtual void RegisterUserPrefs(PrefRegistrySyncable* registry) OVERRIDE;	34 virtual void RegisterUserPrefs(PrefRegistrySyncable* registry) OVERRIDE;

35 virtual bool ServiceRedirectedInIncognito() const OVERRIDE;	35 virtual bool ServiceRedirectedInIncognito() const OVERRIDE;

	36 virtual bool ServiceHasOwnInstanceInIncognito() const OVERRIDE;

36	37

37 DISALLOW_COPY_AND_ASSIGN(ChromeGeolocationPermissionContextFactory);	38 DISALLOW_COPY_AND_ASSIGN(ChromeGeolocationPermissionContextFactory);

38 };	39 };

39	40

40 #endif // CHROME_BROWSER_GEOLOCATION_CHROME_GEOLOCATION_PERMISSION_CONTEXT_FACT ORY_H_	41 #endif // CHROME_BROWSER_GEOLOCATION_CHROME_GEOLOCATION_PERMISSION_CONTEXT_FACT ORY_H_

OLD	NEW