runtime/bin/process_patch.dart - Issue 13548002: Add Iterable.fold (and Stream.fold) which replace `reduce`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/process_patch.dart

Issue 13548002: Add Iterable.fold (and Stream.fold) which replace `reduce`. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/process_patch.dart

diff --git a/runtime/bin/process_patch.dart b/runtime/bin/process_patch.dart

index 21d09b6e33b5e5c44368e8ecf1497c6df14b5262..281259b67233ce904ddcad1baf151d7e1d07f848 100644

--- a/runtime/bin/process_patch.dart

+++ b/runtime/bin/process_patch.dart

@@ -300,7 +300,7 @@ Future<ProcessResult> _runNonInteractiveProcess(String path,

// Setup stdout handling.

Future<StringBuffer> stdout = p.stdout

.transform(new StringDecoder(stdoutEncoding))

- .reduce(

+ .fold(

new StringBuffer(),

(buf, data) {

buf.write(data);

@@ -309,7 +309,7 @@ Future<ProcessResult> _runNonInteractiveProcess(String path,

Future<StringBuffer> stderr = p.stderr

.transform(new StringDecoder(stderrEncoding))

- .reduce(

+ .fold(

new StringBuffer(),

(buf, data) {

buf.write(data);

« no previous file with comments | « pkg/scheduled_test/test/descriptor/utils.dart ('k') | runtime/bin/vmstats/bargraph.dart » ('j') | no next file with comments »