[Contextual Search] Trigger the translation one-box.

chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
index 9fe767649a63a5accbcf424d9c390262917a2542..f34f35be5725cde8c4127f0c4abbda4d4a8a4525 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
@@ -268,10 +268,12 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
         private final boolean mDoPreventPreload;
         private final int mStartAdjust;
         private final int mEndAdjust;
+        private final String mContextLanguage;
 
         public FakeResponseOnMainThread(boolean isNetworkUnavailable, int responseCode,
                                         String searchTerm, String displayText, String alternateTerm,
-                                        boolean doPreventPreload, int startAdjust, int endAdjudst) {
+                                        boolean doPreventPreload, int startAdjust, int endAdjudst,
+                                        String contextLanguage) {
             mIsNetworkUnavailable = isNetworkUnavailable;
             mResponseCode = responseCode;
             mSearchTerm = searchTerm;
@@ -280,13 +282,14 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
             mDoPreventPreload = doPreventPreload;
             mStartAdjust = startAdjust;
             mEndAdjust = endAdjudst;
+            mContextLanguage = contextLanguage;
         }
 
         @Override
         public void run() {
-            mFakeServer.handleSearchTermResolutionResponse(
-                    mIsNetworkUnavailable, mResponseCode, mSearchTerm, mDisplayText,
-                    mAlternateTerm, mDoPreventPreload, mStartAdjust, mEndAdjust);
+            mFakeServer.handleSearchTermResolutionResponse(mIsNetworkUnavailable, mResponseCode,
+                    mSearchTerm, mDisplayText, mAlternateTerm, mDoPreventPreload, mStartAdjust,
+                    mEndAdjust, mContextLanguage);
         }
     }
 
@@ -297,20 +300,20 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
     private void fakeResponse(boolean isNetworkUnavailable, int responseCode,
             String searchTerm, String displayText, String alternateTerm, boolean doPreventPreload) {
         fakeResponse(isNetworkUnavailable, responseCode, searchTerm, displayText, alternateTerm,
-                doPreventPreload, 0, 0);
+                doPreventPreload, 0, 0, "");
     }
 
     /**
      * Fakes a server response with the parameters given.
      * {@See ContextualSearchManager#handleSearchTermResolutionResponse}.
      */
-    private void fakeResponse(boolean isNetworkUnavailable, int responseCode,
-            String searchTerm, String displayText, String alternateTerm, boolean doPreventPreload,
-            int startAdjust, int endAdjust) {
+    private void fakeResponse(boolean isNetworkUnavailable, int responseCode, String searchTerm,
+            String displayText, String alternateTerm, boolean doPreventPreload, int startAdjust,
+            int endAdjust, String contextLanguage) {
         if (mFakeServer.getSearchTermRequested() != null) {
-            getInstrumentation().runOnMainSync(
-                    new FakeResponseOnMainThread(isNetworkUnavailable, responseCode, searchTerm,
-                            displayText, alternateTerm, doPreventPreload, startAdjust, endAdjust));
+            getInstrumentation().runOnMainSync(new FakeResponseOnMainThread(isNetworkUnavailable,
+                    responseCode, searchTerm, displayText, alternateTerm, doPreventPreload,
+                    startAdjust, endAdjust, contextLanguage));
         }
     }
 
@@ -449,10 +452,14 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
      */
     private void assertLoadedSearchTermMatches(String searchTerm) {
         boolean doesMatch = false;
+        String message = "but there was no loaded URL!";
         if (mFakeServer != null) {
             doesMatch = mFakeServer.getLoadedUrl().contains("q=" + searchTerm);
+            // TODO(donnd): remove the following line once the Translate API is updated!
+            doesMatch = doesMatch || mFakeServer.getLoadedUrl().contains("tlitetxt=" + searchTerm);

[pedro (no code reviews), 2015/11/05 02:09:58]

Nit: Please add a comment explaining what is happening here (that the
translation is triggered by forcing with a certain query, therefore in that case
we need to check for other parameter). Otherwise it will not be obvious to
others not familiar with the translate API.

[Donn Denman, 2015/11/05 17:51:08]

Done.

+            message = "in URL: " + mFakeServer.getLoadedUrl();
         }
-        assertTrue(doesMatch);
+        assertTrue("Expected to find searchTerm " + searchTerm + ", " + message, doesMatch);
     }
 
     private void assertContainsParameters(String searchTerm, String alternateTerm) {
@@ -2166,7 +2173,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
         waitForPanelToPeekAndAssert();
 
         fakeResponse(false, 200, "Intelligence", "United States Intelligence", "alternate-term",
-                false, -14, 0);
+                false, -14, 0, "");
         waitForSelectionToBe("United States Intelligence");
     }
 
@@ -2410,4 +2417,34 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
         assertTrue(mFakeServer.hasRemovedUrl(url2));
         assertTrue(mFakeServer.hasRemovedUrl(url3));
     }
+
+    /**
+     * Tests that a simple Tap with language determination triggers translation.
+     */
+    @SmallTest
+    @Feature({"ContextualSearch"})
+    @Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
+    @CommandLineFlags.Add(ContextualSearchFieldTrial.TRANSLATION_ONEBOX_ENABLED + "=true")
+    public void testTapWithLanguage() throws InterruptedException, TimeoutException {
+        // Tapping a german word should trigger translation.
+        simulateTapSearch("german");
+
+        // Make sure we tried to trigger translate.
+        assertTrue(mManager.getRequest().isTranslationForced());
+    }
+
+    /**
+     * Tests that a simple Tap without language determination does not trigger translation.
+     */
+    @SmallTest
+    @Feature({"ContextualSearch"})
+    @Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
+    @CommandLineFlags.Add(ContextualSearchFieldTrial.TRANSLATION_ONEBOX_ENABLED + "=true")
+    public void testTapWithoutLanguage() throws InterruptedException, TimeoutException {
+        // Tapping an English word should NOT trigger translation.
+        simulateTapSearch("search");
+
+        // Make sure we did not try to trigger translate.
+        assertFalse(mManager.getRequest().isTranslationForced());
+    }
 }