Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4316)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java

Issue 1354763003: [Contextual Search] Trigger the translation one-box. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable for non-English users, for now. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
index da24817ceb6d8101132a6a9d62ac0c1d31ec58a3..1f8ebdd34b8510320a2a8184c18a9434e81715b3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
@@ -52,6 +52,10 @@ public class ContextualSearchFieldTrial {
private static final int DEFAULT_TAP_NAVIGATION_DETECTION_DELAY = 16;
private static final String NAVIGATION_DETECTION_DELAY = "tap_navigation_detection_delay";
+ // Translation.
+ private static final String TRANSLATION_ONEBOX_ENABLED = "translation_onebox_enabled";
+
+ // Tap handling.
private static final int UNLIMITED_TAPS = -1;
private static final int DEFAULT_TAP_RESOLVE_LIMIT_FOR_DECIDED = UNLIMITED_TAPS;
private static final int DEFAULT_TAP_PREFETCH_LIMIT_FOR_DECIDED = UNLIMITED_TAPS;
@@ -62,6 +66,7 @@ public class ContextualSearchFieldTrial {
private static Boolean sEnabled;
private static Boolean sIsPeekPromoEnabled;
private static Integer sPeekPromoMaxCount;
+ private static Boolean sIsTranslationOneboxEnabled;
/**
* Don't instantiate.
@@ -263,6 +268,16 @@ public class ContextualSearchFieldTrial {
return sPeekPromoMaxCount.intValue();
}
+ /**
+ * @return Whether triggering a translation Onebox in the SERP is enabled.
+ */
+ static boolean isTranslationOneboxEnabled() {
+ if (sIsTranslationOneboxEnabled == null) {
+ sIsTranslationOneboxEnabled = getBooleanParam(TRANSLATION_ONEBOX_ENABLED);
+ }
+ return sIsTranslationOneboxEnabled.booleanValue();
+ }
+
// --------------------------------------------------------------------------------------------
// Helpers.
// --------------------------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698