Chromium Code Reviews| Index: chrome/browser/android/contextualsearch/contextual_search_manager.h |
| diff --git a/chrome/browser/android/contextualsearch/contextual_search_manager.h b/chrome/browser/android/contextualsearch/contextual_search_manager.h |
| index f9e76039d6d8cfc68e7418b4257ca3326c1c472b..d089c2439d96c81336ac23c06fc343ab3bd1a5e1 100644 |
| --- a/chrome/browser/android/contextualsearch/contextual_search_manager.h |
| +++ b/chrome/browser/android/contextualsearch/contextual_search_manager.h |
| @@ -46,16 +46,14 @@ class ContextualSearchManager { |
| jobject j_base_content_view_core, |
| jboolean j_may_send_base_page_url); |
| + // Gets the target language for translation purposes. |
| + // TODO(donnd): Can we get rid of the jobject if it's not being used? |
|
pedro (no code reviews)
2015/09/23 18:33:55
The jobj is being implicitly used when you pass th
Donn Denman
2015/10/09 22:08:23
Acknowledged.
|
| + base::android::ScopedJavaLocalRef<jstring> GetTargetLanguage(JNIEnv* env, |
| + jobject obj); |
| + |
| private: |
| - // TODO(donnd): encapsulate these response parameters? |
| - void OnSearchTermResolutionResponse(bool is_invalid, |
| - int response_code, |
| - const std::string& search_term, |
| - const std::string& display_text, |
| - const std::string& alternate_term, |
| - bool prevent_preload, |
| - int selection_start_adjust, |
| - int selection_end_adjust); |
| + void OnSearchTermResolutionResponse( |
| + const ResolvedSearchTerm& resolved_search_term); |
| // Calls back to Java with the surrounding text to be displayed. |
| void OnSurroundingTextAvailable(const std::string& before_text, |