Avoid misaligned read/write on little endian platforms

Avoid misaligned read/write on little endian platforms

Asan build with -fsanitize=alignment flag crash on
out/Debug/base_unittests --gtest_filter=Base*

Code does not use memcpy for consistency with code around.

BUG=532120
Committed: https://crrev.com/59888b9a537fed903b7e09523644c2aedb44b467
Cr-Commit-Position: refs/heads/master@{#350033}

[Vitaly Buka (NO REVIEWS), 2015-09-17 20:39:51]

The CQ bit was checked by vitalybuka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-17 20:40:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354743002/20001

[Vitaly Buka (NO REVIEWS), 2015-09-17 21:03:34]

vitalybuka@chromium.org changed reviewers:
+ jschuh@chromium.org, rsleevi@chromium.org, yunlian@chromium.org

[Vitaly Buka (NO REVIEWS), 2015-09-17 21:04:59]

vitalybuka@chromium.org changed reviewers:
+ avakulenko@chromium.org

[Alex Vakulenko (Google), 2015-09-17 21:15:16]

avakulenko@google.com changed reviewers:
+ avakulenko@google.com

[Alex Vakulenko (Google), 2015-09-17 21:15:17]

https://codereview.chromium.org/1354743002/diff/60001/third_party/modp_b64/mo...
File third_party/modp_b64/modp_b64.cc (right):

https://codereview.chromium.org/1354743002/diff/60001/third_party/modp_b64/mo...
third_party/modp_b64/modp_b64.cc:215: src += 4;
Why do we even care about src from this point on? Just increment |y| and don't
touch |src| at all. So, remove this line, and in the loop below do "y += 4;" and
you should be all good.

[Vitaly Buka (NO REVIEWS), 2015-09-17 21:19:36]

The CQ bit was checked by vitalybuka@chromium.org to run a CQ dry run

[Vitaly Buka (NO REVIEWS), 2015-09-17 21:19:42]

https://codereview.chromium.org/1354743002/diff/60001/third_party/modp_b64/mo...
File third_party/modp_b64/modp_b64.cc (right):

https://codereview.chromium.org/1354743002/diff/60001/third_party/modp_b64/mo...
third_party/modp_b64/modp_b64.cc:215: src += 4;
On 2015/09/17 21:15:17, Alex Vakulenko (Google) wrote:
> Why do we even care about src from this point on? Just increment |y| and don't
> touch |src| at all. So, remove this line, and in the loop below do "y += 4;"
and
> you should be all good.

Done.

[commit-bot: I haz the power, 2015-09-17 21:20:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354743002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354743002/80001

[Alex Vakulenko (Google), 2015-09-17 21:20:49]

lgtm

[commit-bot: I haz the power, 2015-09-17 22:17:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-17 22:17:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Vitaly Buka (NO REVIEWS), 2015-09-17 22:24:18]

The CQ bit was checked by vitalybuka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-17 22:24:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354743002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354743002/80001

[commit-bot: I haz the power, 2015-09-17 23:12:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-17 23:12:09]

Dry run: This issue passed the CQ dry run.

[jschuh, 2015-09-17 23:46:45]

rubberstamp owner lgtm

[Vitaly Buka (NO REVIEWS), 2015-09-21 20:21:00]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2015-09-21 20:21:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354743002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354743002/80001

[commit-bot: I haz the power, 2015-09-21 21:49:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-21 21:50:28]

Patchset 5 (id:??) landed as
https://crrev.com/59888b9a537fed903b7e09523644c2aedb44b467
Cr-Commit-Position: refs/heads/master@{#350033}