Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1354723003: Update MediaKeyStatus enum values (Closed)

Created:
5 years, 3 months ago by jrummell
Modified:
5 years, 2 months ago
Reviewers:
bbudge, ddorwin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, eme-reviews_chromium.org, binji+watch_chromium.org, tzik, jam, feature-media-reviews_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, bradnelson+warch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update MediaKeyStatus enum values Replace OutputNotAllowed with OutputRestricted and add Released. These values have been added to the spec, so allow them to be returned from the CDM. BUG=528347 Committed: https://crrev.com/7c04ca6d03f4f4df96e93c24fa591eac1965a6f2 Cr-Commit-Position: refs/heads/master@{#351878}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : use right DEPS value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/content_decryptor_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/cdm_key_information.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/blink/webcontentdecryptionmodulesession_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/cdm/ppapi/cdm_adapter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/api/private/pp_content_decryptor.idl View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/private/pp_content_decryptor.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
jrummell
PTAL.
5 years, 3 months ago (2015-09-17 20:08:02 UTC) #2
ddorwin
lgtm
5 years, 2 months ago (2015-09-30 05:37:27 UTC) #3
jrummell
+bbudge@ for OWNERS review of ppapi/ and content/renderer/pepper/
5 years, 2 months ago (2015-09-30 17:49:47 UTC) #5
bbudge
ppapi and content/renderer/pepper LGTM
5 years, 2 months ago (2015-09-30 18:03:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354723003/1
5 years, 2 months ago (2015-09-30 21:01:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/126175) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-09-30 21:08:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354723003/20001
5 years, 2 months ago (2015-10-01 02:22:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/104235) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-01 02:26:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354723003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354723003/40001
5 years, 2 months ago (2015-10-01 17:30:58 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-01 20:43:34 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 20:44:07 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7c04ca6d03f4f4df96e93c24fa591eac1965a6f2
Cr-Commit-Position: refs/heads/master@{#351878}

Powered by Google App Engine
This is Rietveld 408576698