Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Side by Side Diff: extensions/shell/app_shell.gyp

Issue 1354703002: Delete dead code related to the removed helper apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove verify_no_objc.sh as well Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'app_shell.gypi', 7 'app_shell.gypi',
8 ], 8 ],
9 'variables': { 9 'variables': {
10 # Product name is used for Mac bundle. 10 # Product name is used for Mac bundle.
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 '${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH}/Frameworks', 172 '${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH}/Frameworks',
173 ], 173 ],
174 }, 174 },
175 { 175 {
176 # Modify the Info.plist as needed. 176 # Modify the Info.plist as needed.
177 'postbuild_name': 'Tweak Info.plist', 177 'postbuild_name': 'Tweak Info.plist',
178 'action': ['../../build/mac/tweak_info_plist.py', 178 'action': ['../../build/mac/tweak_info_plist.py',
179 '--scm=1', 179 '--scm=1',
180 '--version=<(app_shell_version)'], 180 '--version=<(app_shell_version)'],
181 }, 181 },
182 {
183 # This postbuild step is responsible for creating the following
184 # helpers:
185 #
186 # App Shell Helper EH.app and App Shell Helper NP.app are
187 # created from App Shell Helper.app.
188 #
189 # The EH helper is marked for an executable heap. The NP helper
190 # is marked for no PIE (ASLR).
191 'postbuild_name': 'Make More Helpers',
192 'action': [
193 '../../build/mac/make_more_helpers.sh',
194 'Frameworks',
195 '<(app_shell_product_name)',
196 ],
197 },
198 {
199 # Make sure there isn't any Objective-C in the shell's
200 # executable.
201 'postbuild_name': 'Verify No Objective-C',
202 'action': [
203 '../../build/mac/verify_no_objc.sh',
204 ],
205 },
206 ], 182 ],
207 }], 183 }],
208 ], 184 ],
209 }, 185 },
210 { 186 {
211 'target_name': 'app_shell_unittests', 187 'target_name': 'app_shell_unittests',
212 'type': 'executable', 188 'type': 'executable',
213 'dependencies': [ 189 'dependencies': [
214 'app_shell_lib', 190 'app_shell_lib',
215 '<(DEPTH)/base/base.gyp:base', 191 '<(DEPTH)/base/base.gyp:base',
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 # targets. In this case, --breakpad=0, --keystone=0, and --scm=0 385 # targets. In this case, --breakpad=0, --keystone=0, and --scm=0
410 # are used because Breakpad, Keystone, and SCM keys are 386 # are used because Breakpad, Keystone, and SCM keys are
411 # never placed into the helper. 387 # never placed into the helper.
412 'postbuild_name': 'Tweak Info.plist', 388 'postbuild_name': 'Tweak Info.plist',
413 'action': ['../../build/mac/tweak_info_plist.py', 389 'action': ['../../build/mac/tweak_info_plist.py',
414 '--breakpad=0', 390 '--breakpad=0',
415 '--keystone=0', 391 '--keystone=0',
416 '--scm=0', 392 '--scm=0',
417 '--version=<(app_shell_version)'], 393 '--version=<(app_shell_version)'],
418 }, 394 },
419 {
420 # Make sure there isn't any Objective-C in the helper app's
421 # executable.
422 'postbuild_name': 'Verify No Objective-C',
423 'action': [
424 '../../build/mac/verify_no_objc.sh',
425 ],
426 },
427 ], 395 ],
428 }, # target app_shell_helper 396 }, # target app_shell_helper
429 ], 397 ],
430 }], # OS=="mac" 398 }], # OS=="mac"
431 ['test_isolation_mode != "noop"', { 399 ['test_isolation_mode != "noop"', {
432 'targets': [ 400 'targets': [
433 { 401 {
434 'target_name': 'app_shell_unittests_run', 402 'target_name': 'app_shell_unittests_run',
435 'type': 'none', 403 'type': 'none',
436 'dependencies': [ 404 'dependencies': [
437 'app_shell_unittests', 405 'app_shell_unittests',
438 ], 406 ],
439 'includes': [ 407 'includes': [
440 '../../build/isolate.gypi', 408 '../../build/isolate.gypi',
441 ], 409 ],
442 'sources': [ 410 'sources': [
443 'app_shell_unittests.isolate', 411 'app_shell_unittests.isolate',
444 ], 412 ],
445 }, 413 },
446 ], 414 ],
447 }], 415 }],
448 ], 416 ],
449 } 417 }
OLDNEW
« chrome/browser/memory_details_mac.cc ('K') | « content/content_shell.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698