Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: src/IceTypes.def

Issue 1354673002: Fix call instructions to check parameter types for consistency. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix minimal build to work. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTypes.def
diff --git a/src/IceTypes.def b/src/IceTypes.def
index b86dba899518e6f79b869cf5bc054b1b0001be8f..80c33fc939079a9215f51b9cae3450d5fac704ae 100644
--- a/src/IceTypes.def
+++ b/src/IceTypes.def
@@ -54,25 +54,27 @@
// F - Is floating point value (scalar or vector).
// IA - Is integer arithmetic type
// LS - true if load/store allowed on type.
+// P - true if can be used for parameter of call.
// CR - Result type of compare instruction for argument type
// (IceType_void if disallowed)
#define ICETYPE_PROPS_TABLE \
- /* Enum Value V I F IA LS CR */ \
- X(IceType_void, 0, 0, 0, 0, 0, IceType_void) \
- X(IceType_i1, 0, 1, 0, 0, 0, IceType_i1) \
- X(IceType_i8, 0, 1, 0, 1, 1, IceType_i1) \
- X(IceType_i16, 0, 1, 0, 1, 1, IceType_i1) \
- X(IceType_i32, 0, 1, 0, 1, 1, IceType_i1) \
- X(IceType_i64, 0, 1, 0, 1, 1, IceType_i1) \
- X(IceType_f32, 0, 0, 1, 0, 1, IceType_i1) \
- X(IceType_f64, 0, 0, 1, 0, 1, IceType_i1) \
- X(IceType_v4i1, 1, 1, 0, 0, 0, IceType_v4i1) \
- X(IceType_v8i1, 1, 1, 0, 0, 0, IceType_v8i1) \
- X(IceType_v16i1, 1, 1, 0, 0, 0, IceType_v16i1) \
- X(IceType_v16i8, 1, 1, 0, 1, 1, IceType_v16i1) \
- X(IceType_v8i16, 1, 1, 0, 1, 1, IceType_v8i1) \
- X(IceType_v4i32, 1, 1, 0, 1, 1, IceType_v4i1) \
- X(IceType_v4f32, 1, 0, 1, 0, 1, IceType_v4i1) \
-//#define X(tag, IsVec, IsInt, IsFloat, IsIntArith, IsLoadStore, CompareResult)
+ /* Enum Value V I F IA LS P CR */ \
+ X(IceType_void, 0, 0, 0, 0, 0, 0, IceType_void) \
+ X(IceType_i1, 0, 1, 0, 0, 0, 0, IceType_i1) \
+ X(IceType_i8, 0, 1, 0, 1, 1, 0, IceType_i1) \
+ X(IceType_i16, 0, 1, 0, 1, 1, 0, IceType_i1) \
+ X(IceType_i32, 0, 1, 0, 1, 1, 1, IceType_i1) \
+ X(IceType_i64, 0, 1, 0, 1, 1, 1, IceType_i1) \
+ X(IceType_f32, 0, 0, 1, 0, 1, 1, IceType_i1) \
+ X(IceType_f64, 0, 0, 1, 0, 1, 1, IceType_i1) \
+ X(IceType_v4i1, 1, 1, 0, 0, 0, 1, IceType_v4i1) \
+ X(IceType_v8i1, 1, 1, 0, 0, 0, 1, IceType_v8i1) \
+ X(IceType_v16i1, 1, 1, 0, 0, 0, 1, IceType_v16i1) \
+ X(IceType_v16i8, 1, 1, 0, 1, 1, 1, IceType_v16i1) \
+ X(IceType_v8i16, 1, 1, 0, 1, 1, 1, IceType_v8i1) \
+ X(IceType_v4i32, 1, 1, 0, 1, 1, 1, IceType_v4i1) \
+ X(IceType_v4f32, 1, 0, 1, 0, 1, 1, IceType_v4i1) \
+//#define X(tag, IsVec, IsInt, IsFloat, IsIntArith, IsLoadStore, IsParam, \
Jim Stichnoth 2015/09/17 19:56:46 As long as you're changing the \ alignment... Cou
Karl 2015/09/18 17:22:49 Done.
+// CompareResult)
#endif // SUBZERO_SRC_ICETYPES_DEF
« no previous file with comments | « src/IceTypes.cpp ('k') | src/PNaClTranslator.cpp » ('j') | src/PNaClTranslator.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698