Fix call instructions to check parameter types for consistency.

Fix call instructions to check parameter types for consistency.

Checks each parameter of a call against the corresponding function
signature.  It also checks that parameters are valid PNaCl parameter
types, unless the call is to an intrinsic.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4309
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ff94f59aec64a95c7c1e42d09e2cb7a4cbe63b9a

[Karl, 2015-09-17 17:18:04]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-09-17 19:56:46]

https://codereview.chromium.org/1354673002/diff/20001/src/IceTypes.def
File src/IceTypes.def (right):

https://codereview.chromium.org/1354673002/diff/20001/src/IceTypes.def#newcode77
src/IceTypes.def:77: //#define X(tag, IsVec, IsInt, IsFloat, IsIntArith,
IsLoadStore, IsParam, \
As long as you're changing the \ alignment...

Could you change all the \ characters in this file to be aligned in column 80? 
This is to match what clang-format already does in the .h/.cpp files.

https://codereview.chromium.org/1354673002/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1354673002/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:2711: Ice::Variable *Dest = (ReturnType ==
Ice::IceType_void)
Before creating Dest, you should also check for
  ReturnType == Ice::IceType_void || isCallParameterType(ReturnType)
and print a similar error if that's not true.

https://codereview.chromium.org/1354673002/diff/20001/tests_lit/llvm2ice_test...
File tests_lit/llvm2ice_tests/phi_invalid.test (right):

https://codereview.chromium.org/1354673002/diff/20001/tests_lit/llvm2ice_test...
tests_lit/llvm2ice_tests/phi_invalid.test:4: ; REQUIRES: no_minimal_build
This was fixed about 3 commits ago, please revert and verify.

https://codereview.chromium.org/1354673002/diff/20001/tests_lit/parse_errs/ca...
File tests_lit/parse_errs/call-fcn-bad-param-type.ll (right):

https://codereview.chromium.org/1354673002/diff/20001/tests_lit/parse_errs/ca...
tests_lit/parse_errs/call-fcn-bad-param-type.ll:1: ; Test that even in a call
parameter matches its declaration, it must still
even if

[Karl, 2015-09-18 17:22:49]

https://codereview.chromium.org/1354673002/diff/20001/src/IceTypes.def
File src/IceTypes.def (right):

https://codereview.chromium.org/1354673002/diff/20001/src/IceTypes.def#newcode77
src/IceTypes.def:77: //#define X(tag, IsVec, IsInt, IsFloat, IsIntArith,
IsLoadStore, IsParam, \
On 2015/09/17 19:56:46, stichnot wrote:
> As long as you're changing the \ alignment...
> 
> Could you change all the \ characters in this file to be aligned in column 80?

> This is to match what clang-format already does in the .h/.cpp files.

Done.

https://codereview.chromium.org/1354673002/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1354673002/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:2711: Ice::Variable *Dest = (ReturnType ==
Ice::IceType_void)
On 2015/09/17 19:56:46, stichnot wrote:
> Before creating Dest, you should also check for
>   ReturnType == Ice::IceType_void || isCallParameterType(ReturnType)
> and print a similar error if that's not true.

Done.

https://codereview.chromium.org/1354673002/diff/20001/tests_lit/llvm2ice_test...
File tests_lit/llvm2ice_tests/phi_invalid.test (right):

https://codereview.chromium.org/1354673002/diff/20001/tests_lit/llvm2ice_test...
tests_lit/llvm2ice_tests/phi_invalid.test:4: ; REQUIRES: no_minimal_build
On 2015/09/17 19:56:46, stichnot wrote:
> This was fixed about 3 commits ago, please revert and verify.

Reverted.

https://codereview.chromium.org/1354673002/diff/20001/tests_lit/parse_errs/ca...
File tests_lit/parse_errs/call-fcn-bad-param-type.ll (right):

https://codereview.chromium.org/1354673002/diff/20001/tests_lit/parse_errs/ca...
tests_lit/parse_errs/call-fcn-bad-param-type.ll:1: ; Test that even in a call
parameter matches its declaration, it must still
On 2015/09/17 19:56:46, stichnot wrote:
> even if

Done.

[Jim Stichnoth, 2015-09-18 17:27:49]

lgtm

https://codereview.chromium.org/1354673002/diff/60001/tests_lit/parse_errs/ca...
File tests_lit/parse_errs/call-fcn-bad-return-type.ll (right):

https://codereview.chromium.org/1354673002/diff/60001/tests_lit/parse_errs/ca...
tests_lit/parse_errs/call-fcn-bad-return-type.ll:2: ; a legal call parameter
type (unless declaration is intrinsic).
s/parameter/return/ (I think, because "parameter type" excludes void)

[Karl, 2015-09-18 17:37:50]

Committed patchset #6 (id:100001) manually as
ff94f59aec64a95c7c1e42d09e2cb7a4cbe63b9a (presubmit successful).

[Karl, 2015-09-18 17:37:57]

https://codereview.chromium.org/1354673002/diff/60001/tests_lit/parse_errs/ca...
File tests_lit/parse_errs/call-fcn-bad-return-type.ll (right):

https://codereview.chromium.org/1354673002/diff/60001/tests_lit/parse_errs/ca...
tests_lit/parse_errs/call-fcn-bad-return-type.ll:2: ; a legal call parameter
type (unless declaration is intrinsic).
On 2015/09/18 17:27:49, stichnot wrote:
> s/parameter/return/ (I think, because "parameter type" excludes void)

Done.