Issue 1354643002: Don't use real urls for kiosk_wm just yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1354643002: Don't use real urls for kiosk_wm just yet. (Closed)

Created:
5 years, 3 months ago by ppi

Modified:
5 years, 3 months ago

Reviewers:
tonyg, qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Don't use real urls for kiosk_wm just yet. We need to switch to real urls in one big step, having only some apps in some contexts referenced through real urls leads to confusion. Fixes domokit/devtools#46. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2c4aa25ef08be9ad420123a2d1e3bee92c5a0fc2

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	mojo/devtools/common/docs/mojo_run.md	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	mojo/devtools/common/mojo_run	View		2 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

5 years, 3 months ago (2015-09-17 15:09:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2c4aa25ef08be9ad420123a2d1e3bee92c5a0fc2 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages