Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1354643002: Don't use real urls for kiosk_wm just yet. (Closed)

Created:
5 years, 3 months ago by ppi
Modified:
5 years, 3 months ago
Reviewers:
tonyg, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't use real urls for kiosk_wm just yet. We need to switch to real urls in one big step, having only some apps in some contexts referenced through real urls leads to confusion. Fixes domokit/devtools#46. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2c4aa25ef08be9ad420123a2d1e3bee92c5a0fc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M mojo/devtools/common/docs/mojo_run.md View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/devtools/common/mojo_run View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Ben or Tony, ptal.
5 years, 3 months ago (2015-09-17 15:07:27 UTC) #2
qsr
lgtm
5 years, 3 months ago (2015-09-17 15:08:53 UTC) #3
ppi
5 years, 3 months ago (2015-09-17 15:09:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c4aa25ef08be9ad420123a2d1e3bee92c5a0fc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698