Merge to master: contention over isolate data slots

Merge to master: contention over isolate data slots

Work on this was first performed on the XFA branch, since
it has additional requirements (FXJSE layer) that needed
to be accomodated by the solution.

(cherry picked from commit ed7b2b50aa1744e0bc5a60bef12c61fa91d863b7)
Original Review URL: https://codereview.chromium.org/1351173002 .

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/70bc04b16646c92f221c5aa56831b01d6ec7c1ca

[Tom Sepez, 2015-09-22 16:05:16]

tsepez@chromium.org changed reviewers:
+ jochen@chromium.org, thestig@chromium.org

[Tom Sepez, 2015-09-22 16:06:27]

Jochen, Lei, quick sanity check.  The merge is basically deleting the xfa
specific stuff.

[Lei Zhang, 2015-09-22 20:27:32]

Do you need to merge the code in fpdfsdk/include/javascript/JS_Define.h?

[Tom Sepez, 2015-09-22 22:34:32]

On 2015/09/22 20:27:32, Lei Zhang wrote:
> Do you need to merge the code in fpdfsdk/include/javascript/JS_Define.h?
Apparently not.  We get objects in a different manner under XFA.  Not sure where
they diverged.

[Lei Zhang, 2015-09-22 22:36:17]

lgtm

[Tom Sepez, 2015-09-22 22:49:18]

Committed patchset #3 (id:10006) manually as
70bc04b16646c92f221c5aa56831b01d6ec7c1ca (presubmit successful).

[Tom Sepez, 2015-09-22 23:03:07]

On 2015/09/22 22:49:18, Tom Sepez wrote:
> Committed patchset #3 (id:10006) manually as
> 70bc04b16646c92f221c5aa56831b01d6ec7c1ca (presubmit successful).

And its reverted.  Will need to do things the XFA way, after all ...