Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1354573002: Revert "[profiler] Make no frame region detection code more robust", "Fix ASAN after r30777" and "F… (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
alph
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[profiler] Make no frame region detection code more robust", "Fix ASAN after r30777" and "Fix MSAN warning after r30777 (try 2)" This reverts commits 12c7bc9a226859c3200609495689592a675a21af, cb0b3592258173c4d20e1500cbd5731e15b9e8b1, and a6e00c6a9f5a8abf2747293d7452dd0cf572c99e, because they introduced weird flaky crashes in random places now at least in the arm simulator, where it see that quite often now on different change sets, i.e. see http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/8138/steps/Check%20%28flakes%29/logs/LoadICFastApi_DirectC.. and https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20mipsel%20-%20sim/builds/2566/steps/Check%20%28flakes%29/logs/LoadICFastApi_DirectC.. for example. TBR=alph@chromium.org BUG=chromium:529931 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true LOG=N Committed: https://crrev.com/7be2555151c63ec5e0ec23da980bd302b5baa9ed Cr-Commit-Position: refs/heads/master@{#30786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -68 lines) Patch
M src/sampler.cc View 2 chunks +0 lines, -68 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354573002/1
5 years, 3 months ago (2015-09-17 06:31:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 06:31:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7be2555151c63ec5e0ec23da980bd302b5baa9ed Cr-Commit-Position: refs/heads/master@{#30786}
5 years, 3 months ago (2015-09-17 06:31:41 UTC) #4
alph
Thanks. I'm looking into these.
5 years, 3 months ago (2015-09-17 06:35:24 UTC) #5
Benedikt Meurer
5 years, 3 months ago (2015-09-17 06:36:38 UTC) #6
Message was sent while issue was closed.
Please don't try to fix *SAN issues in the tree. That makes it harder to revert
CLs. If you notice an issue, try to revert the offending CL, and only reland
with a fix after you pass the tests locally and on the relevant try bots.

Powered by Google App Engine
This is Rietveld 408576698