Exclude in-use origins from storage evictions for all QuotaEvictionPolicies.

chrome/browser/engagement/site_engagement_eviction_policy_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/run_loop.h"
 #include "base/thread_task_runner_handle.h"
 #include "chrome/browser/engagement/site_engagement_eviction_policy.h"
@@ skipping 139 matching lines @@
 }
 
 class SiteEngagementEvictionPolicyTest : public testing::Test {
  public:
   SiteEngagementEvictionPolicyTest()
       : score_provider_(new TestSiteEngagementScoreProvider()),
         storage_policy_(new content::MockSpecialStoragePolicy()) {}
 
   ~SiteEngagementEvictionPolicyTest() override {}
 
+  GURL CalculateEvictionOrigin(const std::map<GURL, int64>& usage,

[raymes, 2015/09/22 07:16:10]

nit: suggest renaming this to CalculatEvictionOriginWithExceptions

[calamity, 2015/09/23 01:55:21]

Good call. Done.

+                               const std::set<GURL>& exceptions) {
+    return SiteEngagementEvictionPolicy::CalculateEvictionOriginForTests(
+        storage_policy_, score_provider_.get(), exceptions, usage,
+        kGlobalQuota);
+  }
+
   GURL CalculateEvictionOrigin(const std::map<GURL, int64>& usage) {
-    return SiteEngagementEvictionPolicy::CalculateEvictionOriginForTests(
-        storage_policy_, score_provider_.get(), usage, kGlobalQuota);
+    return CalculateEvictionOrigin(usage, std::set<GURL>());
   }
 
   TestSiteEngagementScoreProvider* score_provider() {
     return score_provider_.get();
   }
 
   content::MockSpecialStoragePolicy* storage_policy() {
     return storage_policy_.get();
   }
 
@@ skipping 57 matching lines @@
   EXPECT_EQ(url2, CalculateEvictionOrigin(usage));
 
   // Durable storage doesn't get evicted.
   storage_policy()->AddDurable(url2);
   EXPECT_EQ(url1, CalculateEvictionOrigin(usage));
 
   // Unlimited storage doesn't get evicted.
   storage_policy()->AddUnlimited(url1);
   EXPECT_EQ(GURL(), CalculateEvictionOrigin(usage));
 }
+
+TEST_F(SiteEngagementEvictionPolicyTest, Exceptions) {
+  GURL url1("http://www.google.com");
+  GURL url2("http://www.example.com");
+
+  std::map<GURL, int64> usage;
+  usage[url1] = 10 * 1024;
+  usage[url2] = 10 * 1024;
+
+  score_provider()->SetScore(url1, 50);
+  score_provider()->SetScore(url2, 25);
+
+  EXPECT_EQ(url2, CalculateEvictionOrigin(usage));
+
+  // The policy should respect exceptions.
+  std::set<GURL> exceptions;
+  exceptions.insert(url2);
+  EXPECT_EQ(url1, CalculateEvictionOrigin(usage, exceptions));
+}