Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1354523003: Fix temp_zone scoping when parsing inner function literals (Closed)

Created:
5 years, 3 months ago by conradw
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, titzer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix temp_zone scoping when parsing inner function literals BUG=v8:4392 LOG=Y Committed: https://crrev.com/b185ed40611d8b5b1a6b8eea7288c28bc5d9b4d8 Cr-Commit-Position: refs/heads/master@{#30792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/ast.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parser.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
conradw
PTAL
5 years, 3 months ago (2015-09-17 09:18:58 UTC) #2
Michael Starzinger
LGTM.
5 years, 3 months ago (2015-09-17 09:28:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354523003/1
5 years, 3 months ago (2015-09-17 09:30:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 09:38:28 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 09:38:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b185ed40611d8b5b1a6b8eea7288c28bc5d9b4d8
Cr-Commit-Position: refs/heads/master@{#30792}

Powered by Google App Engine
This is Rietveld 408576698