Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 13545002: Add list of Skia trybots to run CLs against, along with existing lists of Chrome trybots (Closed)

Created:
7 years, 8 months ago by epoger
Modified:
7 years, 8 months ago
Reviewers:
borenet, rmistry
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add list of Skia trybots to run CLs against, along with existing lists of Chrome trybots (SkipBuildbotRuns) Committed: https://code.google.com/p/skia/source/detail?r=8522

Patch Set 1 #

Patch Set 2 : add_complete_skia_compile_list #

Patch Set 3 : reduce_skia_compile_list #

Total comments: 4

Patch Set 4 : commas_instead_of_spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
D trybots_to_run/README.txt View 1 chunk +0 lines, -8 lines 0 comments Download
A + trybots_to_run/chrome/README.txt View 1 chunk +1 line, -1 line 0 comments Download
A + trybots_to_run/chrome/depsroll View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trybots_to_run/chrome/layout View 0 chunks +-1 lines, --1 lines 0 comments Download
D trybots_to_run/depsroll View 1 chunk +0 lines, -1 line 0 comments Download
D trybots_to_run/layout View 1 chunk +0 lines, -1 line 0 comments Download
A trybots_to_run/skia/README.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A trybots_to_run/skia/compile View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
epoger
Patchset 1 just moves the existing Chrome trybot lists into a "chrome" subdir, to make ...
7 years, 8 months ago (2013-04-03 15:21:36 UTC) #1
epoger
Patchset 2 adds a complete list of *all* compile-only Skia trybots. I will pare that ...
7 years, 8 months ago (2013-04-03 16:46:25 UTC) #2
epoger
Ready to review at patchset 3. https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile File trybots_to_run/skia/compile (right): https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile#newcode1 trybots_to_run/skia/compile:1: Skia_ChromeOS_Alex_Compile_Debug_32 Skia_Linux_NoGPU_Compile_Debug_32 Skia_MacMiniLion_Float_Compile_Debug_32 ...
7 years, 8 months ago (2013-04-03 16:59:37 UTC) #3
borenet
On 2013/04/03 16:59:37, epoger wrote: > Ready to review at patchset 3. > > https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile ...
7 years, 8 months ago (2013-04-03 17:06:59 UTC) #4
rmistry
https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile File trybots_to_run/skia/compile (right): https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile#newcode1 trybots_to_run/skia/compile:1: Skia_ChromeOS_Alex_Compile_Debug_32 Skia_Linux_NoGPU_Compile_Debug_32 Skia_MacMiniLion_Float_Compile_Debug_32 Skia_MacMiniLion_Float_Compile_Release_64 Skia_MacMini_10_8_Float_Compile_Debug_32 Skia_MacMini_10_8_Float_Compile_Release_64 Skia_Mac_Float_Compile_Debug_32 Skia_Mac_Float_Compile_Release_64 Skia_Nexus10_4-1_Float_Compile_Debug_32 ...
7 years, 8 months ago (2013-04-03 17:09:38 UTC) #5
borenet
https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile File trybots_to_run/skia/compile (right): https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile#newcode1 trybots_to_run/skia/compile:1: Skia_ChromeOS_Alex_Compile_Debug_32 Skia_Linux_NoGPU_Compile_Debug_32 Skia_MacMiniLion_Float_Compile_Debug_32 Skia_MacMiniLion_Float_Compile_Release_64 Skia_MacMini_10_8_Float_Compile_Debug_32 Skia_MacMini_10_8_Float_Compile_Release_64 Skia_Mac_Float_Compile_Debug_32 Skia_Mac_Float_Compile_Release_64 Skia_Nexus10_4-1_Float_Compile_Debug_32 ...
7 years, 8 months ago (2013-04-03 17:10:45 UTC) #6
rmistry
On 2013/04/03 17:10:45, borenet wrote: > https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile > File trybots_to_run/skia/compile (right): > > https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile#newcode1 > ...
7 years, 8 months ago (2013-04-03 17:14:45 UTC) #7
rmistry
On 2013/04/03 17:14:45, rmistry wrote: > On 2013/04/03 17:10:45, borenet wrote: > > https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile > ...
7 years, 8 months ago (2013-04-03 17:15:53 UTC) #8
epoger
On 2013/04/03 17:14:45, rmistry wrote: > On 2013/04/03 17:10:45, borenet wrote: > > https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile > ...
7 years, 8 months ago (2013-04-03 17:16:13 UTC) #9
epoger
https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile File trybots_to_run/skia/compile (right): https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile#newcode1 trybots_to_run/skia/compile:1: Skia_ChromeOS_Alex_Compile_Debug_32 Skia_Linux_NoGPU_Compile_Debug_32 Skia_MacMiniLion_Float_Compile_Debug_32 Skia_MacMiniLion_Float_Compile_Release_64 Skia_MacMini_10_8_Float_Compile_Debug_32 Skia_MacMini_10_8_Float_Compile_Release_64 Skia_Mac_Float_Compile_Debug_32 Skia_Mac_Float_Compile_Release_64 Skia_Nexus10_4-1_Float_Compile_Debug_32 ...
7 years, 8 months ago (2013-04-03 18:39:55 UTC) #10
borenet
On 2013/04/03 18:39:55, epoger wrote: > https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile > File trybots_to_run/skia/compile (right): > > https://codereview.chromium.org/13545002/diff/6002/trybots_to_run/skia/compile#newcode1 > ...
7 years, 8 months ago (2013-04-03 18:43:23 UTC) #11
epoger
Committed patchset #4 manually as r8522 (presubmit successful).
7 years, 8 months ago (2013-04-03 18:48:26 UTC) #12
epoger
7 years, 8 months ago (2013-04-04 17:38:17 UTC) #13
Message was sent while issue was closed.
Check out this cool command line I can now run to make sure my CL won't break
any warnings-as-errors on various platforms:

tools/submit_try $CHANGENAME --bot $(cat trybots_to_run/skia/compile) -r $(svn
info | grep ^Revision | awk '{print $2}')

I just ran it for the first time on
https://codereview.chromium.org/13650002/#ps18002

Powered by Google App Engine
This is Rietveld 408576698