Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2445)

Unified Diff: base/trace_event/trace_event_argument_unittest.cc

Issue 1354493003: [tracing] Don't use dot-based path expansion in TracedValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix cc display list tracing Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/trace_event_argument.cc ('k') | cc/playback/display_item_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_argument_unittest.cc
diff --git a/base/trace_event/trace_event_argument_unittest.cc b/base/trace_event/trace_event_argument_unittest.cc
index cb1cf2ef1d57cac30abdb073799eab29f28a9270..c1233ac3a3c85d60a50e80746dde6a280ba40569 100644
--- a/base/trace_event/trace_event_argument_unittest.cc
+++ b/base/trace_event/trace_event_argument_unittest.cc
@@ -22,6 +22,19 @@ TEST(TraceEventArgumentTest, FlatDictionary) {
json);
}
+TEST(TraceEventArgumentTest, NoDotPathExpansion) {
+ scoped_refptr<TracedValue> value = new TracedValue();
+ value->SetInteger("in.t", 2014);
+ value->SetDouble("doub.le", 0.0);
+ value->SetBoolean("bo.ol", true);
+ value->SetString("str.ing", "str.ing");
+ std::string json;
+ value->AppendAsTraceFormat(&json);
+ EXPECT_EQ(
+ "{\"bo.ol\":true,\"doub.le\":0.0,\"in.t\":2014,\"str.ing\":\"str.ing\"}",
+ json);
+}
+
TEST(TraceEventArgumentTest, Hierarchy) {
scoped_refptr<TracedValue> value = new TracedValue();
value->SetInteger("i0", 2014);
« no previous file with comments | « base/trace_event/trace_event_argument.cc ('k') | cc/playback/display_item_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698