gpu/command_buffer/service/in_process_command_buffer.cc - Issue 1354483004: Re-land: ui: Add GLImage unit test framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/in_process_command_buffer.cc

Issue 1354483004: Re-land: ui: Add GLImage unit test framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: still need lsan suppression Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/in_process_command_buffer.cc

diff --git a/gpu/command_buffer/service/in_process_command_buffer.cc b/gpu/command_buffer/service/in_process_command_buffer.cc

index 19e361619cdfcd4e3ae69ce08a6afa7f8cf78607..59bb85237cb3f2ee4b6e1705bfb8247af870e395 100644

--- a/gpu/command_buffer/service/in_process_command_buffer.cc

+++ b/gpu/command_buffer/service/in_process_command_buffer.cc

@@ -699,7 +699,7 @@ void InProcessCommandBuffer::CreateImageOnGpuThread(

case gfx::SHARED_MEMORY_BUFFER: {

scoped_refptr<gfx::GLImageSharedMemory> image(

new gfx::GLImageSharedMemory(size, internalformat));

- if (!image->Initialize(handle, format)) {

+ if (!image->Initialize(handle.handle, handle.id, format)) {

LOG(ERROR) << "Failed to initialize image.";

return;

}