Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1354453002: Repurposed a now-redundant BlinkPlatformImpl::addTraceEvent override to be able to support bind_id (Closed)

Created:
5 years, 3 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang, jam
CC:
chromium-reviews, darin-cc_chromium.org, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Repurposed a now-redundant BlinkPlatformImpl::addTraceEvent override to add bind_id, as well as increase flags to an int (to be consistent with base/). R=thestig BUG=532726 Committed: https://crrev.com/3e54b578f78ad45f1c5b0fa42c98ded7d45cd91c Cr-Commit-Position: refs/heads/master@{#349979}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M content/child/blink_platform_impl.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
oystein (OOO til 10th of July)
ptal!
5 years, 3 months ago (2015-09-17 00:40:38 UTC) #2
Lei Zhang
I don't think I'm the right reviewer. i.e. not an owner here.
5 years, 3 months ago (2015-09-17 06:19:42 UTC) #3
oystein (OOO til 10th of July)
On 2015/09/17 06:19:42, Lei Zhang wrote: > I don't think I'm the right reviewer. i.e. ...
5 years, 3 months ago (2015-09-17 15:39:11 UTC) #4
Lei Zhang
On 2015/09/17 15:39:11, Oystein wrote: > On 2015/09/17 06:19:42, Lei Zhang wrote: > > I ...
5 years, 3 months ago (2015-09-17 18:08:04 UTC) #5
Lei Zhang
This goes to jam@ since he reviewed r264488
5 years, 3 months ago (2015-09-17 18:11:00 UTC) #7
oystein (OOO til 10th of July)
On 2015/09/17 18:08:04, Lei Zhang wrote: > On 2015/09/17 15:39:11, Oystein wrote: > > On ...
5 years, 3 months ago (2015-09-17 18:15:24 UTC) #8
oystein (OOO til 10th of July)
jam: ptal :) Blink side of this is lgtm'd at https://codereview.chromium.org/1347113004/
5 years, 3 months ago (2015-09-18 20:50:35 UTC) #9
jam
lgtm
5 years, 3 months ago (2015-09-21 16:52:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354453002/20001
5 years, 3 months ago (2015-09-21 18:01:19 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-21 18:52:24 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 18:53:03 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e54b578f78ad45f1c5b0fa42c98ded7d45cd91c
Cr-Commit-Position: refs/heads/master@{#349979}

Powered by Google App Engine
This is Rietveld 408576698