Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1354443003: RefCountedLeakDetector: Remove unused methods for suppressing leaks (Closed)

Created:
5 years, 3 months ago by kouhei (in TOK)
Modified:
5 years, 3 months ago
Reviewers:
*haraken, hajimehoshi
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

RefCountedLeakDetector: Remove unused methods for suppressing leaks BUG=372309 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202407

Patch Set 1 #

Patch Set 2 : remove include too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -34 lines) Patch
M Source/wtf/RefCountedLeakCounter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/wtf/RefCountedLeakCounter.cpp View 1 3 chunks +4 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kouhei (in TOK)
5 years, 3 months ago (2015-09-16 23:52:21 UTC) #3
haraken
LGTM Is RefCountedLeakCounter still used?
5 years, 3 months ago (2015-09-16 23:53:40 UTC) #4
kouhei (in TOK)
We should remove the RefCountedLeakDetector class in long term, but wanted to clean it out ...
5 years, 3 months ago (2015-09-16 23:53:47 UTC) #5
haraken
On 2015/09/16 23:53:47, kouhei (travelling) wrote: > We should remove the RefCountedLeakDetector class in long ...
5 years, 3 months ago (2015-09-16 23:54:07 UTC) #6
kouhei (in TOK)
On 2015/09/16 23:53:40, haraken wrote: > LGTM > > Is RefCountedLeakCounter still used? Yes. It ...
5 years, 3 months ago (2015-09-16 23:54:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354443003/20001
5 years, 3 months ago (2015-09-16 23:55:23 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 01:18:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202407

Powered by Google App Engine
This is Rietveld 408576698