Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1354433004: Make prettyprinter useful in gdb. (Closed)

Created:
5 years, 3 months ago by neis
Modified:
5 years, 3 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make prettyprinter useful in gdb. R=rossberg BUG= Committed: https://crrev.com/191a0cb6dd1df1eafcbd10f0dcccc9f15642c115 Cr-Commit-Position: refs/heads/master@{#30866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/prettyprinter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rossberg
lgtm
5 years, 3 months ago (2015-09-22 15:19:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354433004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354433004/1
5 years, 3 months ago (2015-09-22 15:34:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 15:57:09 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 15:57:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/191a0cb6dd1df1eafcbd10f0dcccc9f15642c115
Cr-Commit-Position: refs/heads/master@{#30866}

Powered by Google App Engine
This is Rietveld 408576698