Issue 1354433003: Add a mojo::test::ScopedTestDir and convert tests to use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1354433003: Add a mojo::test::ScopedTestDir and convert tests to use it. (Closed)

Created:
5 years, 3 months ago by viettrungluu

Modified:
5 years, 3 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add a mojo::test::ScopedTestDir and convert tests to use it. This centralizes our dependency on various base stuff (and it turns out that our tests only need various base file things for very trivial purposes). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c04943544a3edd3de0f3a5b08ac0302440f97dbe

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -62 lines)			Patch
M	mojo/edk/embedder/platform_channel_pair_posix_unittest.cc	View	6 chunks	+7 lines, -23 lines	0 comments	Download
M	mojo/edk/system/multiprocess_message_pipe_unittest.cc	View	4 chunks	+3 lines, -8 lines	0 comments	Download
M	mojo/edk/system/platform_handle_dispatcher_unittest.cc	View	3 chunks	+5 lines, -13 lines	0 comments	Download
M	mojo/edk/system/raw_channel_unittest.cc	View	4 chunks	+4 lines, -10 lines	0 comments	Download
M	mojo/edk/system/remote_message_pipe_unittest.cc	View	4 chunks	+3 lines, -8 lines	0 comments	Download
M	mojo/edk/test/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	mojo/edk/test/scoped_test_dir.h	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	mojo/edk/test/scoped_test_dir.cc	View	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 3 months ago (2015-09-17 20:31:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c04943544a3edd3de0f3a5b08ac0302440f97dbe (presubmit successful).

Expand Messages | Collapse Messages