Issue 135443003: Remove MarkupAccumulator::appendNodeValue() method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135443003: Remove MarkupAccumulator::appendNodeValue() method (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
esprehn, abarth-chromium

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@using_namespace_header

Visibility:
Public.

More Reviews

Description

Remove MarkupAccumulator::appendNodeValue() method Remove MarkupAccumulator::appendNodeValue() method and merge it into MarkupAccumulator::appendText() as this is the only caller. Now that we know the Node is actually a Text node, update the implementation to call CharacterData::data() instead of Node::nodeValue() which is virtual. Also update CharacterData::data() to return a const reference to avoid unnecessary ref churn on the String. R=esprehn, abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165154

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -21 lines)			Patch
M	Source/core/dom/CharacterData.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/MarkupAccumulator.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/editing/MarkupAccumulator.cpp	View	2 chunks	+13 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135443003/1

6 years, 11 months ago (2014-01-15 18:17:30 UTC) #3

Message was sent while issue was closed.

Change committed as 165154

Expand Messages | Collapse Messages