Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2156)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 135443002: Fix race condition introduced in r242200 where AwContentsIoThreadClient is queried before a subfram… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/aw_contents_io_thread_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_content_browser_client.cc
===================================================================
--- android_webview/browser/aw_content_browser_client.cc (revision 244357)
+++ android_webview/browser/aw_content_browser_client.cc (working copy)
@@ -7,6 +7,7 @@
#include "android_webview/browser/aw_browser_context.h"
#include "android_webview/browser/aw_browser_main_parts.h"
#include "android_webview/browser/aw_contents_client_bridge_base.h"
+#include "android_webview/browser/aw_contents_io_thread_client.h"
#include "android_webview/browser/aw_cookie_access_policy.h"
#include "android_webview/browser/aw_quota_permission_context.h"
#include "android_webview/browser/aw_web_preferences_populater.h"
@@ -56,6 +57,7 @@
void OnShouldOverrideUrlLoading(int routing_id,
const base::string16& url,
bool* ignore_navigation);
+ void OnSubFrameCreated(int parent_render_frame_id, int child_render_frame_id);
private:
virtual ~AwContentsMessageFilter();
@@ -85,6 +87,7 @@
IPC_BEGIN_MESSAGE_MAP_EX(AwContentsMessageFilter, message, *message_was_ok)
IPC_MESSAGE_HANDLER(AwViewHostMsg_ShouldOverrideUrlLoading,
OnShouldOverrideUrlLoading)
+ IPC_MESSAGE_HANDLER(AwViewHostMsg_SubFrameCreated, OnSubFrameCreated)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -106,6 +109,12 @@
}
}
+void AwContentsMessageFilter::OnSubFrameCreated(int parent_render_frame_id,
+ int child_render_frame_id) {
+ AwContentsIoThreadClient::SubFrameCreated(
+ process_id_, parent_render_frame_id, child_render_frame_id);
+}
+
class AwAccessTokenStore : public content::AccessTokenStore {
public:
AwAccessTokenStore() { }
« no previous file with comments | « no previous file | android_webview/browser/aw_contents_io_thread_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698