Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: android_webview/browser/aw_contents_io_thread_client.h

Issue 135443002: Fix race condition introduced in r242200 where AwContentsIoThreadClient is queried before a subfram… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_IO_THREAD_CLIENT_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_IO_THREAD_CLIENT_H_
6 #define ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_IO_THREAD_CLIENT_H_ 6 #define ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_IO_THREAD_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 // This method is called on the IO thread only. 55 // This method is called on the IO thread only.
56 virtual CacheMode GetCacheMode() const = 0; 56 virtual CacheMode GetCacheMode() const = 0;
57 57
58 // This will attempt to fetch the AwContentsIoThreadClient for the given 58 // This will attempt to fetch the AwContentsIoThreadClient for the given
59 // |render_process_id|, |render_frame_id| pair. 59 // |render_process_id|, |render_frame_id| pair.
60 // This method can be called from any thread. 60 // This method can be called from any thread.
61 // An empty scoped_ptr is a valid return value. 61 // An empty scoped_ptr is a valid return value.
62 static scoped_ptr<AwContentsIoThreadClient> FromID(int render_process_id, 62 static scoped_ptr<AwContentsIoThreadClient> FromID(int render_process_id,
63 int render_frame_id); 63 int render_frame_id);
64 64
65 // Called on the IO thread when a subframe is created.
66 static void SubFrameCreated(int render_process_id,
67 int parent_render_frame_id,
68 int child_render_frame_id);
69
65 // This method is called on the IO thread only. 70 // This method is called on the IO thread only.
66 virtual scoped_ptr<InterceptedRequestData> ShouldInterceptRequest( 71 virtual scoped_ptr<InterceptedRequestData> ShouldInterceptRequest(
67 const GURL& location, 72 const GURL& location,
68 const net::URLRequest* request) = 0; 73 const net::URLRequest* request) = 0;
69 74
70 // Retrieve the AllowContentAccess setting value of this AwContents. 75 // Retrieve the AllowContentAccess setting value of this AwContents.
71 // This method is called on the IO thread only. 76 // This method is called on the IO thread only.
72 virtual bool ShouldBlockContentUrls() const = 0; 77 virtual bool ShouldBlockContentUrls() const = 0;
73 78
74 // Retrieve the AllowFileAccess setting value of this AwContents. 79 // Retrieve the AllowFileAccess setting value of this AwContents.
(...skipping 17 matching lines...) Expand all
92 // WebViewClient.onReceivedLoginRequest for arguments. Note that |account| 97 // WebViewClient.onReceivedLoginRequest for arguments. Note that |account|
93 // may be empty. 98 // may be empty.
94 virtual void NewLoginRequest(const std::string& realm, 99 virtual void NewLoginRequest(const std::string& realm,
95 const std::string& account, 100 const std::string& account,
96 const std::string& args) = 0; 101 const std::string& args) = 0;
97 }; 102 };
98 103
99 } // namespace android_webview 104 } // namespace android_webview
100 105
101 #endif // ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_IO_THREAD_CLIENT_H_ 106 #endif // ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_IO_THREAD_CLIENT_H_
OLDNEW
« no previous file with comments | « android_webview/browser/aw_content_browser_client.cc ('k') | android_webview/common/render_view_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698