Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: google_apis/gaia/account_tracker_unittest.cc

Issue 1354373002: Cleanup: Pass std::string as const reference from google_apis/ and components/gcm_driver/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase against ToT Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gaia/account_tracker.cc ('k') | google_apis/gaia/oauth2_token_service_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gaia/account_tracker_unittest.cc
diff --git a/google_apis/gaia/account_tracker_unittest.cc b/google_apis/gaia/account_tracker_unittest.cc
index 61fded91a1ad6689022140f189ad7fc5b4a990b4..e846bb14dab2549d6a7110844e3c7771e3b59d04 100644
--- a/google_apis/gaia/account_tracker_unittest.cc
+++ b/google_apis/gaia/account_tracker_unittest.cc
@@ -29,7 +29,7 @@ enum TrackingEventType {
SIGN_OUT
};
-std::string AccountKeyToObfuscatedId(const std::string email) {
+std::string AccountKeyToObfuscatedId(const std::string& email) {
return "obfid-" + email;
}
@@ -294,7 +294,7 @@ class IdentityAccountTrackerTest : public testing::Test {
// Helpers to pass fake events to the tracker.
- void NotifyLogin(const std::string account_key) {
+ void NotifyLogin(const std::string& account_key) {
identity_provider()->LogIn(account_key);
}
@@ -314,7 +314,7 @@ class IdentityAccountTrackerTest : public testing::Test {
username, "access_token-" + username, base::Time::Max());
}
- std::string GetValidTokenInfoResponse(const std::string account_key) {
+ std::string GetValidTokenInfoResponse(const std::string& account_key) {
return std::string("{ \"id\": \"") + AccountKeyToObfuscatedId(account_key) +
"\" }";
}
« no previous file with comments | « google_apis/gaia/account_tracker.cc ('k') | google_apis/gaia/oauth2_token_service_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698