components/gcm_driver/gcm_stats_recorder_impl.cc - Issue 1354373002: Cleanup: Pass std::string as const reference from google_apis/ and components/gcm_driver/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl.cc

Issue 1354373002: Cleanup: Pass std::string as const reference from google_apis/ and components/gcm_driver/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/gcm_stats_recorder_impl.cc

diff --git a/components/gcm_driver/gcm_stats_recorder_impl.cc b/components/gcm_driver/gcm_stats_recorder_impl.cc

index 1e40fb58a7ea90c98f9fbcfe13e37dd86f54a666..e1731c707602ff7b9bdc57846152dfe83f9edb5a 100644

--- a/components/gcm_driver/gcm_stats_recorder_impl.cc

+++ b/components/gcm_driver/gcm_stats_recorder_impl.cc

@@ -206,8 +206,8 @@ void GCMStatsRecorderImpl::RecordCheckinSuccess() {

RecordCheckin("Checkin succeeded", std::string());

}

-void GCMStatsRecorderImpl::RecordCheckinFailure(std::string status,

- bool will_retry) {

+void GCMStatsRecorderImpl::RecordCheckinFailure(const std::string& status,

+ bool will_retry) {

if (!is_recording_)

return;

RecordCheckin("Checkin failed", base::StringPrintf(

« no previous file with comments | « components/gcm_driver/gcm_stats_recorder_impl.h ('k') | google_apis/gaia/account_tracker.h » ('j') | no next file with comments »