Cleanup: Pass std::string as const reference from google_apis/ and components/gcm_driver/

google_apis/gaia/account_tracker.h

Index: google_apis/gaia/account_tracker.h
diff --git a/google_apis/gaia/account_tracker.h b/google_apis/gaia/account_tracker.h
index 61d3748868bf593a70eebdf17f3c8ada3c0c55ab..d59a5451679a84d8437dbb0348a5862225571b81 100644
--- a/google_apis/gaia/account_tracker.h
+++ b/google_apis/gaia/account_tracker.h
@@ -97,12 +97,17 @@ class AccountTracker : public OAuth2TokenService::Observer,
   void NotifyAccountRemoved(const AccountState& account);
   void NotifySignInChanged(const AccountState& account);
 
-  void UpdateSignInState(const std::string account_key, bool is_signed_in);
+  void UpdateSignInState(const std::string& account_key, bool is_signed_in);
 
-  void StartTrackingAccount(const std::string account_key);
+  void StartTrackingAccount(const std::string& account_key);
+
+  // Note: |account_key| is passed by value here, because the original
+  // object is stored in |accounts_| and it will be destroyed after

[Roger Tawa OOO till Jul 10th, 2015/09/21 20:47:40]

nit: is --> may be

[ki.stfu, 2015/09/21 21:34:54]

Done.

+  // erasing the key from the map.
   void StopTrackingAccount(const std::string account_key);
+
   void StopTrackingAllAccounts();
-  void StartFetchingUserInfo(const std::string account_key);
+  void StartFetchingUserInfo(const std::string& account_key);
   void DeleteFetcher(AccountIdFetcher* fetcher);
 
   IdentityProvider* identity_provider_;  // Not owned.