Cleanup: Pass std::string as const reference from google_apis/ and components/gcm_driver/

google_apis/gaia/account_tracker.cc

Index: google_apis/gaia/account_tracker.cc
diff --git a/google_apis/gaia/account_tracker.cc b/google_apis/gaia/account_tracker.cc
index f424863c9e8c6f9ab1d18aa73d02ac5769a2f508..d40cd20a59b0bd5d75162177953e7342c468c7a7 100644
--- a/google_apis/gaia/account_tracker.cc
+++ b/google_apis/gaia/account_tracker.cc
@@ -177,7 +177,7 @@ void AccountTracker::NotifySignInChanged(const AccountState& account) {
                     OnAccountSignInChanged(account.ids, account.is_signed_in));
 }
 
-void AccountTracker::UpdateSignInState(const std::string account_key,
+void AccountTracker::UpdateSignInState(const std::string& account_key,
                                        bool is_signed_in) {
   // TODO(robliao): Remove ScopedTracker below once https://crbug.com/422460 is
   // fixed.
@@ -198,7 +198,7 @@ void AccountTracker::UpdateSignInState(const std::string account_key,
     NotifySignInChanged(account);
 }
 
-void AccountTracker::StartTrackingAccount(const std::string account_key) {
+void AccountTracker::StartTrackingAccount(const std::string& account_key) {
   // TODO(robliao): Remove ScopedTracker below once https://crbug.com/422460 is
   // fixed.
   tracked_objects::ScopedTracker tracking_profile(
@@ -215,7 +215,7 @@ void AccountTracker::StartTrackingAccount(const std::string account_key) {
   }
 }
 
-void AccountTracker::StopTrackingAccount(const std::string account_key) {
+void AccountTracker::StopTrackingAccount(const std::string& account_key) {

[Roger Tawa OOO till Jul 10th, 2015/09/20 20:40:08]

I don't think this one can be changed without further cleanup.  When line 235
calls StopTrackingAccount(), the key it passes is from the |accounts_| map. 
When the entry is removed at line 226, the |account_key| argument is deleted. 
The behaviour at lines 229 and 230 becomes undefined.

One solution is to make a copy of string at line 235.  A better solution would
be to make a copy of key inside this function and then only use the copy. 
Either way please add a comment to explain what is happening.

[ki.stfu, 2015/09/21 06:15:39]

Thanks for catching it!
I think we can leave it as is, instead of passing the account_key by reference
and then copying it to a local variable.

   DVLOG(1) << "StopTracking " << account_key;
   if (ContainsKey(accounts_, account_key)) {
     AccountState& account = accounts_[account_key];
@@ -235,7 +235,7 @@ void AccountTracker::StopTrackingAllAccounts() {
     StopTrackingAccount(accounts_.begin()->first);
 }
 
-void AccountTracker::StartFetchingUserInfo(const std::string account_key) {
+void AccountTracker::StartFetchingUserInfo(const std::string& account_key) {
   // TODO(robliao): Remove ScopedTracker below once https://crbug.com/422460 is
   // fixed.
   tracked_objects::ScopedTracker tracking_profile(