content/shell/browser/shell_mac.mm - Issue 1354363002: Cleanup: Pass std::string as const reference from content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_mac.mm

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/shell_mac.mm

diff --git a/content/shell/browser/shell_mac.mm b/content/shell/browser/shell_mac.mm

index 0c741d99ce9b09304e72fc36f3cb89666f101c2e..e33138f4a668f58d4fb16e48e3d7844dfba2d29e 100644

--- a/content/shell/browser/shell_mac.mm

+++ b/content/shell/browser/shell_mac.mm

@@ -303,7 +303,7 @@ void Shell::ActionPerformed(int control) {

}

-void Shell::URLEntered(std::string url_string) {

+void Shell::URLEntered(const std::string& url_string) {

if (!url_string.empty()) {

GURL url(url_string);

if (!url.has_scheme())

« no previous file with comments | « content/shell/browser/shell.h ('k') | no next file » | no next file with comments »