content/public/test/content_browser_test_utils.cc - Issue 1354363002: Cleanup: Pass std::string as const reference from content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/content_browser_test_utils.cc

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/test/content_browser_test_utils.cc

diff --git a/content/public/test/content_browser_test_utils.cc b/content/public/test/content_browser_test_utils.cc

index d20e98e2c7f0322dfd8e0f26de5dde72ab5d6f0f..dab6f7270b64d76440f4654a9f00bc5ce2700a83 100644

--- a/content/public/test/content_browser_test_utils.cc

+++ b/content/public/test/content_browser_test_utils.cc

@@ -53,8 +53,10 @@ void ReloadBlockUntilNavigationsComplete(Shell* window,

same_tab_observer.Wait();

}

-void LoadDataWithBaseURL(Shell* window, const GURL& url,

- const std::string data, const GURL& base_url) {

+void LoadDataWithBaseURL(Shell* window,

+ const GURL& url,

+ const std::string& data,

+ const GURL& base_url) {

WaitForLoadStop(window->web_contents());

TestNavigationObserver same_tab_observer(window->web_contents(), 1);

« no previous file with comments | « content/public/test/content_browser_test_utils.h ('k') | content/renderer/history_entry.cc » ('j') | no next file with comments »