content/common/gpu/gpu_channel_manager.h - Issue 1354363002: Cleanup: Pass std::string as const reference from content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_channel_manager.h

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/gpu_channel_manager.h

diff --git a/content/common/gpu/gpu_channel_manager.h b/content/common/gpu/gpu_channel_manager.h

index 51f2a3aaffc65d73d5854c04df43349bad96cb74..a6731c62620689d1850f47f8d534ea5a04964526 100644

--- a/content/common/gpu/gpu_channel_manager.h

+++ b/content/common/gpu/gpu_channel_manager.h

@@ -145,7 +145,7 @@ class CONTENT_EXPORT GpuChannelManager : public IPC::Listener,

int32 client_id,

const GPUCreateCommandBufferConfig& init_params,

int32 route_id);

- void OnLoadedShader(std::string shader);

+ void OnLoadedShader(const std::string& shader);

void DestroyGpuMemoryBuffer(gfx::GpuMemoryBufferId id, int client_id);

void DestroyGpuMemoryBufferOnIO(gfx::GpuMemoryBufferId id, int client_id);

void OnDestroyGpuMemoryBuffer(gfx::GpuMemoryBufferId id,

« no previous file with comments | « content/common/cc_messages_perftest.cc ('k') | content/common/gpu/gpu_channel_manager.cc » ('j') | no next file with comments »