content/browser/speech/speech_recognizer_impl_android.h - Issue 1354363002: Cleanup: Pass std::string as const reference from content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognizer_impl_android.h

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/speech/speech_recognition_browsertest.cc ('k') | content/browser/speech/speech_recognizer_impl_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/speech_recognizer_impl_android.h

diff --git a/content/browser/speech/speech_recognizer_impl_android.h b/content/browser/speech/speech_recognizer_impl_android.h

index 11895c441fe059256dfceac21053a55fd55a57cc..9472ca6a9568a824ec528930df654290809bd47c 100644

--- a/content/browser/speech/speech_recognizer_impl_android.h

+++ b/content/browser/speech/speech_recognizer_impl_android.h

@@ -49,8 +49,9 @@ class CONTENT_EXPORT SpeechRecognizerImplAndroid : public SpeechRecognizer {

STATE_AWAITING_FINAL_RESULT

};

- void StartRecognitionOnUIThread(

- std::string language, bool continuous, bool interim_results);

+ void StartRecognitionOnUIThread(const std::string& language,

+ bool continuous,

+ bool interim_results);

void OnRecognitionResultsOnIOThread(SpeechRecognitionResults const &results);

~SpeechRecognizerImplAndroid() override;