content/browser/device_monitor_mac.mm - Issue 1354363002: Cleanup: Pass std::string as const reference from content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_monitor_mac.mm

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/device_monitor_mac.mm

diff --git a/content/browser/device_monitor_mac.mm b/content/browser/device_monitor_mac.mm

index c3c713c5714154547c99c9f860a85e9b91640ef3..36e9a5714b7313b5c241bdb99274cbf9c11ab8fe 100644

--- a/content/browser/device_monitor_mac.mm

+++ b/content/browser/device_monitor_mac.mm

@@ -32,7 +32,7 @@ class DeviceInfo {

kInvalid

};

- DeviceInfo(std::string unique_id, DeviceType type)

+ DeviceInfo(const std::string& unique_id, DeviceType type)

: unique_id_(unique_id), type_(type) {}

// Operator== is needed here to use this class in a std::find. A given

« no previous file with comments | « no previous file | content/browser/fileapi/file_system_dir_url_request_job_unittest.cc » ('j') | no next file with comments »