Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_browsertest.cc

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/barrier_closure.h" 5 #include "base/barrier_closure.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
513 video_renderer.Copy(video_frame, &canvas, media::Context3D()); 513 video_renderer.Copy(video_frame, &canvas, media::Context3D());
514 514
515 ReadbackRequestCallbackTest(quit_callback, bitmap, READBACK_SUCCESS); 515 ReadbackRequestCallbackTest(quit_callback, bitmap, READBACK_SUCCESS);
516 } 516 }
517 517
518 void SetAllowableError(int amount) { allowable_error_ = amount; } 518 void SetAllowableError(int amount) { allowable_error_ = amount; }
519 void SetExcludeRect(gfx::Rect exclude) { exclude_rect_ = exclude; } 519 void SetExcludeRect(gfx::Rect exclude) { exclude_rect_ = exclude; }
520 520
521 GURL TestUrl() override { return GURL(test_url_); } 521 GURL TestUrl() override { return GURL(test_url_); }
522 522
523 void SetTestUrl(std::string url) { test_url_ = url; } 523 void SetTestUrl(const std::string& url) { test_url_ = url; }
524 524
525 // Loads a page two boxes side-by-side, each half the width of 525 // Loads a page two boxes side-by-side, each half the width of
526 // |html_rect_size|, and with different background colors. The test then 526 // |html_rect_size|, and with different background colors. The test then
527 // copies from |copy_rect| region of the page into a bitmap of size 527 // copies from |copy_rect| region of the page into a bitmap of size
528 // |output_size|, and examines the resulting bitmap/VideoFrame. 528 // |output_size|, and examines the resulting bitmap/VideoFrame.
529 // Note that |output_size| may not have the same size as |copy_rect| (e.g. 529 // Note that |output_size| may not have the same size as |copy_rect| (e.g.
530 // when the output is scaled). 530 // when the output is scaled).
531 void PerformTestWithLeftRightRects(const gfx::Size& html_rect_size, 531 void PerformTestWithLeftRightRects(const gfx::Size& html_rect_size,
532 const gfx::Rect& copy_rect, 532 const gfx::Rect& copy_rect,
533 const gfx::Size& output_size, 533 const gfx::Size& output_size,
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
955 kTestCompositingModes); 955 kTestCompositingModes);
956 INSTANTIATE_TEST_CASE_P( 956 INSTANTIATE_TEST_CASE_P(
957 GLAndSoftwareCompositing, 957 GLAndSoftwareCompositing,
958 CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI, 958 CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI,
959 kTestCompositingModes); 959 kTestCompositingModes);
960 960
961 #endif // !defined(OS_ANDROID) && !defined(OS_IOS) 961 #endif // !defined(OS_ANDROID) && !defined(OS_IOS)
962 962
963 } // namespace 963 } // namespace
964 } // namespace content 964 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/p2p/socket_host_test_utils.cc ('k') | content/browser/session_history_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698