Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: content/browser/renderer_host/p2p/socket_host_test_utils.cc

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/p2p/socket_host_test_utils.h" 5 #include "content/browser/renderer_host/p2p/socket_host_test_utils.h"
6 6
7 #include "base/sys_byteorder.h" 7 #include "base/sys_byteorder.h"
8 #include "base/thread_task_runner_handle.h" 8 #include "base/thread_task_runner_handle.h"
9 #include "net/base/completion_callback.h" 9 #include "net/base/completion_callback.h"
10 #include "net/base/io_buffer.h" 10 #include "net/base/io_buffer.h"
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 } 201 }
202 202
203 void CreateStunResponse(std::vector<char>* packet) { 203 void CreateStunResponse(std::vector<char>* packet) {
204 CreateStunPacket(packet, kStunBindingResponse); 204 CreateStunPacket(packet, kStunBindingResponse);
205 } 205 }
206 206
207 void CreateStunError(std::vector<char>* packet) { 207 void CreateStunError(std::vector<char>* packet) {
208 CreateStunPacket(packet, kStunBindingError); 208 CreateStunPacket(packet, kStunBindingError);
209 } 209 }
210 210
211 net::IPEndPoint ParseAddress(const std::string ip_str, uint16 port) { 211 net::IPEndPoint ParseAddress(const std::string& ip_str, uint16 port) {
212 net::IPAddressNumber ip; 212 net::IPAddressNumber ip;
213 EXPECT_TRUE(net::ParseIPLiteralToNumber(ip_str, &ip)); 213 EXPECT_TRUE(net::ParseIPLiteralToNumber(ip_str, &ip));
214 return net::IPEndPoint(ip, port); 214 return net::IPEndPoint(ip, port);
215 } 215 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698