Fix AVD configuration and defaults based on dogfooder input.

build/android/avd.py

Index: build/android/avd.py
diff --git a/build/android/avd.py b/build/android/avd.py
index c9da30f199f34b127f448821551b0016e3d049e0..7c12da7148e4617cb05e6f9b2e5898191d51a295 100755
--- a/build/android/avd.py
+++ b/build/android/avd.py
@@ -23,20 +23,18 @@ from pylib.utils import emulator
 def main(argv):
   # ANDROID_SDK_ROOT needs to be set to the location of the SDK used to launch
   # the emulator to find the system images upon launch.
-  emulator_sdk = os.path.join(constants.EMULATOR_SDK_ROOT, 'android_tools',
-                              'sdk')
+  emulator_sdk = os.path.join(constants.EMULATOR_SDK_ROOT,
+                              'android_tools', 'sdk')
   os.environ['ANDROID_SDK_ROOT'] = emulator_sdk
 
   opt_parser = optparse.OptionParser(description='AVD script.')
   opt_parser.add_option('-n', '--num', dest='emulator_count',
-                        help='Number of emulators to launch.',
+                        help='Number of emulators to launch (default is 1).',
                         type='int', default='1')
-  opt_parser.add_option('--abi', default='arm',
-                        help='Platform of emulators to launch.')
+  opt_parser.add_option('--abi', default='x86',
+                        help='Platform of emulators to launch (x86 default).')
 
   options, _ = opt_parser.parse_args(argv[1:])
-  if options.abi == 'arm':
-    options.abi = 'armeabi-v7a'
 
   logging.basicConfig(level=logging.INFO,
                       format='# %(asctime)-15s: %(message)s')
@@ -45,8 +43,8 @@ def main(argv):
   # Check if KVM is enabled for x86 AVD's and check for x86 system images.
   if options.abi =='x86':
     if not install_emulator_deps.CheckKVM():
-      logging.critical('ERROR: KVM must be enabled in BIOS, and installed. Run '
-                       'install_emulator_deps.py')
+      logging.critical('ERROR: KVM must be enabled in BIOS, and installed. '
+                       'Enable in BIOS and run install_emulator_deps.py')

[pasko-google - do not use, 2013/04/05 09:41:05]

s/Enable in/Enable it in/

[nyquist, 2013/04/05 20:49:35]

Maybe even "Enable KVM in BIOS..."?

[navabi, 2013/04/08 21:41:56]

Done.

       return 1
     elif not install_emulator_deps.CheckX86Image():
       logging.critical('ERROR: System image for x86 AVD not installed. Run '