GLImage support for Android zero-copy pixel buffers

ui/gl/gl_image_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_image.h"
 
 #include "base/debug/trace_event.h"
 #include "ui/gl/gl_image_glx.h"
 #include "ui/gl/gl_image_stub.h"
 #include "ui/gl/gl_implementation.h"
 
 namespace gfx {
 
 scoped_refptr<GLImage> GLImage::CreateGLImage(gfx::PluginWindowHandle window) {
   TRACE_EVENT0("gpu", "GLImage::CreateGLImage");
   switch (GetGLImplementation()) {
     case kGLImplementationOSMesaGL: {

[reveman, 2013/04/05 17:58:07]

if you remove redundant braces below, please remove them from here as well so
it's consistent.

[kaanb, 2013/04/05 18:49:25]

Done.

       return NULL;
     }
     case kGLImplementationDesktopGL: {
       scoped_refptr<GLImageGLX> image(new GLImageGLX(window));
       if (!image->Initialize())
         return NULL;
 
       return image;
     }
     case kGLImplementationEGLGLES2: {

[reveman, 2013/04/05 17:58:07]

and here

[kaanb, 2013/04/05 18:49:25]

Done.

       return NULL;
     }
     case kGLImplementationMockGL:
       return new GLImageStub;
     default:
       NOTREACHED();
       return NULL;
   }
 }
 
+scoped_refptr<GLImage> GLImage::CreateGLImageForPixelBuffer(
+    gfx::PixelBufferHandle buffer, const gfx::Size& size) {
+  TRACE_EVENT0("gpu", "GLImage::CreateGLImageForPixelBuffer");
+  switch (GetGLImplementation()) {
+    case kGLImplementationOSMesaGL:
+    case kGLImplementationDesktopGL:
+    case kGLImplementationEGLGLES2: {

[apatrick_chromium, 2013/04/05 17:35:58]

nit: braces are redundant

[kaanb, 2013/04/05 18:49:25]

Done.

+      return NULL;
+    }
+    case kGLImplementationMockGL:
+      return new GLImageStub;
+    default:
+      NOTREACHED();
+      return NULL;
+  }
+}
+
 }  // namespace gfx