Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: testing/scripts/run_telemetry_as_googletest.py

Issue 1354223004: Run telemetry_gpu_unittests via isolate on "Linux Tests" and trybot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mb.py's fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/scripts/run_telemetry_as_googletest.py
diff --git a/testing/scripts/run_telemetry_as_googletest.py b/testing/scripts/run_telemetry_as_googletest.py
index e6c90cf9b4d590b08271825a90e79510559304e1..9068511486f87db90531387d53713927534dd870 100755
--- a/testing/scripts/run_telemetry_as_googletest.py
+++ b/testing/scripts/run_telemetry_as_googletest.py
@@ -9,7 +9,7 @@ This script attempts to emulate the contract of gtest-style tests
invoked via recipes. The main contract is that the caller passes the
argument:
- --test-launcher-summary-output=[FILENAME]
+ --isolated-script-test-output=[FILENAME]
json is written to that file in the format produced by
common.parse_common_test_results.
@@ -31,10 +31,11 @@ import common
def main():
parser = argparse.ArgumentParser()
parser.add_argument(
- '--test-launcher-summary-output',
+ '--isolated-script-test-output',
type=argparse.FileType('w'),
required=True)
args, rest_args = parser.parse_known_args()
+ print 'Writing results to %s' % args.isolated_script_test_output
Ken Russell (switch to Gerrit) 2015/09/18 23:52:51 Please remove debugging print statement.
nednguyen 2015/09/21 17:26:18 Done.
with common.temporary_file() as tempfile_path:
rc = common.run_command([sys.executable] + rest_args + [
'--write-full-results-to', tempfile_path,
@@ -49,7 +50,7 @@ def main():
'valid': bool(rc <= common.MAX_FAILURES_EXIT_STATUS and
((rc == 0) or failures)),
'failures': failures.keys(),
- }, args.test_launcher_summary_output)
+ }, args.isolated_script_test_output)
return rc

Powered by Google App Engine
This is Rietveld 408576698