Run telemetry_gpu_unittests via isolate on "Linux Tests" and trybot.

chrome/test/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//chrome/chrome_tests.gni")
@@ skipping 626 matching lines @@
         data += [
           "$root_out_dir/base.dll.pdb",
           "$root_out_dir/blink_platform.dll.pdb",
           "$root_out_dir/blink_web.dll.pdb",
           "$root_out_dir/content.dll.pdb",
         ]
       }
     }
   }
 
+  group("telemetry_gpu_unittests_run") {
+    testonly = true
+    deps = [
+      ":telemetry_gpu_unittests",
+    ]
+  }
+
+  group("telemetry_gpu_unittests") {
+    # telemetry/testing/run_tests.py require environment to have a browser.
+    # TODO(nednguyen): make sure that telemetry_gpu_unittests script doesn't
+    # need browser to run. (crbug.com/534585)
+    data_deps = [ "//chrome" ]

[Ken Russell (switch to Gerrit), 2015/09/21 23:04:37]

Thanks for tracking down this problem. I don't understand how this isolate
worked locally. Let's fix crbug.com/534585 quickly so that this dependency can
be removed; otherwise, the isolated telemetry_gpu_unittests won't work on any
non-GN platform (since telemetry_gpu_unittests.isolate and the GYP dependencies
aren't being updated). Understanding this issue now, perhaps it does make sense
to fix crbug.com/534585 first.

[nednguyen, 2015/09/21 23:13:01]

Which are the non-GN platforms? 
Acknowledged. 


Though I think we still don't need to block this patch on fixing
crbug.com/534585. Since your tests in telemetry_gpu_unittests don't touch the
actual browser, it doesn't matter much which platform we use for running it and
the test coverage should be the same.

[Dirk Pranke, 2015/09/22 17:48:52]

Most of them :). Only the main linux release and debug bots have been flipped to
GN at this point.

+
+    data = [
+      # TODO(kbr): refactor the telemetry dependencies more cleanly.
+      "//content/test/gpu/",
+      "//content/test/data/gpu/",
+
+      # For GpuProcess.video
+      "//content/test/data/media/bear.ogv",
+      "//third_party/catapult/",
+
+      # Generic telemetry deps
+      "//build/android/devil/",
+      "//build/android/pylib/",
+      "//build/util/",
+      "//third_party/WebKit/PerformanceTests/resources/jquery.tablesorter.min.js",
+      "//third_party/WebKit/PerformanceTests/resources/statistics.js",
+      "//third_party/flot/jquery.flot.min.js",
+      "//third_party/webpagereplay/",
+      "//tools/telemetry/",
+
+      # From telemetry_gpu_unittests.isolate
+      "//third_party/typ/",
+      "//testing/scripts/common.py",
+      "//testing/scripts/run_telemetry_as_googletest.py",
+    ]
+  }
+
   # TODO(GYP): Delete this after we've converted everything to GN.
   # The _run targets exist only for compatibility w/ GYP.
   group("tab_capture_end2end_tests_run") {
     testonly = true
     deps = [
       ":browser_tests",
     ]
   }
 
   # TODO(GYP): Delete this after we've converted everything to GN.
@@ skipping 1360 matching lines @@
     "//third_party/mojo/src/mojo/edk/system",
   ]
 
   if (!is_android && use_ash) {
     sources += rebase_path(
             chrome_tests_unit_gypi_values.chrome_test_support_unit_ash_sources,
             ".",
             "//chrome")
   }
 }