Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h

Issue 13542003: Add browser test for new user CrOS login flow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
index 8a02b6179a80348281d1b73ca85f41c1a14a9b87..8e19dc12835b4596a95382e1b63456ceb0ed6edd 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
@@ -62,6 +62,7 @@ class LoginDisplayWebUIHandler {
// Show sign-in screen for the given credentials.
virtual void ShowSigninScreenForCreds(const std::string& username,
const std::string& password) = 0;
+ virtual void SetGaiaOriginForTesting(const std::string& arg) = 0;
protected:
virtual ~LoginDisplayWebUIHandler() {}
};
@@ -249,6 +250,9 @@ class SigninScreenHandler
virtual void ShowErrorScreen(LoginDisplay::SigninError error_id) OVERRIDE;
virtual void ShowSigninScreenForCreds(const std::string& username,
const std::string& password) OVERRIDE;
+ virtual void SetGaiaOriginForTesting(const std::string& arg) OVERRIDE {
+ gaia_origin_for_test_ = arg;
+ }
// BrowsingDataRemover::Observer overrides.
virtual void OnBrowsingDataRemoverDone() OVERRIDE;
@@ -435,6 +439,10 @@ class SigninScreenHandler
// NOTIFICATION_AUTH_CANCELLED.
bool has_pending_auth_ui_;
+ // Testing flag, true when we want to use http:// for gaia
Nikita (slow) 2013/04/08 19:56:41 nit: Update comment.
glotov 2013/04/10 13:03:24 Done.
+ // url. Because our test http server does not supporl ssl.
+ std::string gaia_origin_for_test_;
+
DISALLOW_COPY_AND_ASSIGN(SigninScreenHandler);
};

Powered by Google App Engine
This is Rietveld 408576698