src/full-codegen.cc - Issue 13542002: Calling a generator function returns a generator object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 13542002: Calling a generator function returns a generator object (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Fix nits; generator object fields are undefined if not set Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index fb3e2d461cad6f20ab2ceed5215ed82317f58653..72d08358455863a8686a788f2ef8d033464959b1 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -1553,6 +1553,8 @@ void FullCodeGenerator::VisitYield(Yield* expr) {

UNIMPLEMENTED();

Comment cmnt(masm_, "[ Yield");

+ // TODO(wingo): Actually update the iterator state.

+ VisitForEffect(expr->generator_object());

VisitForAccumulatorValue(expr->expression());

// TODO(wingo): Assert that the operand stack depth is 0, at least while

// general yield expressions are unimplemented.

« no previous file with comments | « src/ast.h ('k') | src/heap.h » ('j') | no next file with comments »