Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1354083002: Add simplest service/urlfetch implementation. (Closed)

Created:
5 years, 3 months ago by Vadim Sh.
Modified:
5 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : panic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -4 lines) Patch
M impl/prod/context.go View 1 chunk +6 lines, -3 lines 0 comments Download
A impl/prod/urlfetch.go View 1 chunk +20 lines, -0 lines 0 comments Download
M service/info/context.go View 1 chunk +1 line, -1 line 0 comments Download
A service/urlfetch/context.go View 1 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Vadim Sh.
This feels dumb :-/ But importing "google.golang.org/appengine" in apps that use luci/gae feels even worse.
5 years, 3 months ago (2015-09-18 01:14:14 UTC) #1
Vadim Sh.
https://codereview.chromium.org/1354083002/diff/1/service/urlfetch/context.go File service/urlfetch/context.go (right): https://codereview.chromium.org/1354083002/diff/1/service/urlfetch/context.go#newcode30 service/urlfetch/context.go:30: return http.DefaultTransport no memory implementation for now because this ...
5 years, 3 months ago (2015-09-18 01:15:02 UTC) #2
iannucci
lgtm https://codereview.chromium.org/1354083002/diff/1/service/urlfetch/context.go File service/urlfetch/context.go (right): https://codereview.chromium.org/1354083002/diff/1/service/urlfetch/context.go#newcode30 service/urlfetch/context.go:30: return http.DefaultTransport On 2015/09/18 01:15:02, Vadim Sh. wrote: ...
5 years, 3 months ago (2015-09-18 01:19:38 UTC) #3
Vadim Sh.
https://codereview.chromium.org/1354083002/diff/1/service/urlfetch/context.go File service/urlfetch/context.go (right): https://codereview.chromium.org/1354083002/diff/1/service/urlfetch/context.go#newcode30 service/urlfetch/context.go:30: return http.DefaultTransport On 2015/09/18 01:19:38, iannucci wrote: > On ...
5 years, 3 months ago (2015-09-18 01:22:35 UTC) #4
iannucci
On 2015/09/18 01:22:35, Vadim Sh. wrote: > https://codereview.chromium.org/1354083002/diff/1/service/urlfetch/context.go > File service/urlfetch/context.go (right): > > https://codereview.chromium.org/1354083002/diff/1/service/urlfetch/context.go#newcode30 ...
5 years, 3 months ago (2015-09-18 01:23:31 UTC) #5
Vadim Sh.
ok, panics now
5 years, 3 months ago (2015-09-18 01:28:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354083002/20001
5 years, 3 months ago (2015-09-18 01:28:42 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 01:31:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/8dd23560160d7ee72beb1dff137efeff6757985c

Powered by Google App Engine
This is Rietveld 408576698